Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aiohttp to 3.11.2 #5165

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Bump aiohttp to 3.11.2 #5165

merged 2 commits into from
Nov 18, 2024

Conversation

krysal
Copy link
Member

@krysal krysal commented Nov 15, 2024

Fixes

Related to #4901

Description

Following the first steps of suggestions in the issue, this PR updates aiohttp to see if it helps with the runtime errors after deploying it.

Testing Instructions

Rebuild the image and run the API.

just recreate

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog PRs) or the media properties generator (ov just catalog/generate-docs media-props for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@krysal krysal added 🟧 priority: high Stalls work on the project or its dependents 💻 aspect: code Concerns the software code in the repository dependencies Pull requests that update a dependency file 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🧱 stack: api Related to the Django API labels Nov 15, 2024
@krysal krysal requested a review from a team as a code owner November 15, 2024 17:21
@krysal krysal requested review from obulat and dhruvkb and removed request for a team November 15, 2024 17:21
@krysal krysal marked this pull request as draft November 15, 2024 18:04
@krysal krysal marked this pull request as ready for review November 17, 2024 22:37
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, hope it improves the situation.

Although from reading through issues, I'm more convinced that the last step in Sara's message, removing uvloop, could be the solution. I've found several similar issues, and also a note of a project moving away from uvloop as the new Python version's asyncio is mature and fast, while uvloop causes the problems similar to the ones we are having 1

Footnotes

  1. https://github.com/MagicStack/uvloop/issues/566#issuecomment-2468141695

@krysal
Copy link
Member Author

krysal commented Nov 18, 2024

Thanks, @obulat! That is good observation, I'll look more into uvloop 🧐

@krysal krysal merged commit 284b225 into main Nov 18, 2024
55 checks passed
@krysal krysal deleted the bump_aiohttp branch November 18, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository dependencies Pull requests that update a dependency file 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: api Related to the Django API
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants