Making docker user names consistent

[tejaswarathe]

Fixes

Fixes #1145 by @dhruvkb

Description

This PR changes the docker usernames for services using different names to a single, meaningful name 'ov_user'.
Changes to the airflow user name have been intentionally left out because the airflow image has to use the airflow user name.

Testing Instructions

Checklist

• My pull request has a descriptive title (not a vague title likeUpdate index.md).
• My pull request targets the default branch of the repository (main) or a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.
• I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
  PRs) or the media properties generator (ov just catalog/generate-docs media-props
  for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[dhruvkb]

I'm starting with the review of catalog/Dockerfile.

In this file there are a few references to /home/airflow/.... This the path to the $HOME directory when the username is airflow. When the username is changed to ov_user, the path to the $HOME directory will become /home/ov_user/....

Once you make this change, the CI + CD workflow will be able to proceed further and we'll see if the other checks are passing.

[tejaswarathe]

@dhruvkb What exactly is a DC_USER? Do we need to change it as well?

[dhruvkb]

@tejaswarathe I'm sorry about not checking this earlier but it seems that the airflow image has to use the username of airflow and there is no way around that. They've hardcoded into their Dockerfile in several places.

Can you try reverting the changes to the Airflow code? The CI + CD workflow will be able to run normally then.

[tejaswarathe]

Reverted the name changes for the catalog, completed the change for API, ingestion_server, indexer_worker.

[dhruvkb]

I found two more occurrences of "opener" in the code.

openverse/env.template

Line 1 in 81f0edb

# DC_USER=opener

openverse/justfile

Line 8 in 81f0edb

DC_USER := env_var_or_default("DC_USER", "opener")

[dhruvkb]

Thanks for the contribution @tejaswarathe. LGTM, this is a good normalisation of Docker usernames.

I'll also ask for one more review from another maintainer because it's touching multiple different services but with CI passing, I'm fairly confident that everything is good to go.

[krysal]

Looks good to me! Thank you, @tejaswarathe 💯