Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ov in CI + CD #5262

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Use ov in CI + CD #5262

wants to merge 9 commits into from

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Dec 10, 2024

Fixes

Fixes #4406 by @sarayourfriend

Description

This PR updates the CI + CD workflow to use ov. This should make ov more resilient to accidental breakages.

🚧 WIP:

  • Implement caching for ov and its contents.
  • Speed up workflow by removing redundant steps.
  • Simplify and deduplicate workflow code.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@openverse-bot openverse-bot added 🧱 stack: mgmt Related to repo management and automations 🟨 priority: medium Not blocking but should be addressed soon 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🤖 aspect: dx Concerns developers' experience with the codebase labels Dec 10, 2024
@dhruvkb
Copy link
Member Author

dhruvkb commented Dec 10, 2024

I'm going to come back to this from a Linux machine.

@dhruvkb dhruvkb marked this pull request as ready for review December 11, 2024 02:20
@dhruvkb dhruvkb requested a review from a team as a code owner December 11, 2024 02:20
@dhruvkb dhruvkb requested review from krysal and obulat and removed request for a team December 11, 2024 02:20
@dhruvkb dhruvkb marked this pull request as draft December 11, 2024 02:31
@dhruvkb
Copy link
Member Author

dhruvkb commented Dec 11, 2024

This is definitely not ready for review, lol. How did that happen?

@dhruvkb
Copy link
Member Author

dhruvkb commented Dec 11, 2024

Well, at least the error is new and different.

Comment on lines +28 to +29
./ov build
./ov setup-env
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have thought this would need to include a call to ov just install as well; or is the plan to install specifically for each CI step? If the whole ov container and volume is going to be cached between jobs then installing once at the start would save some time on subsequent jobs 🤔. I don't know if the volume will work that way, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: mgmt Related to repo management and automations
Projects
Status: 🚧 Draft
Development

Successfully merging this pull request may close these issues.

Use ov in CI/CD workflows
3 participants