Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bodyserializer/accept header to openverse api client to correctly authenticate with the API #5330

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

madewithkode
Copy link
Collaborator

Add bodyserializer/accept header to openverse api client to correctly authenticate with the API

Fixes

Fixes #5314 by @obulat

Description

The @openverse/api-client package sends the requests for token to the Openverse Django API with the correct parameters but does not serialize the body to the required x-www-form-urlencoded format. This causes the requests to be sent with an empty body. The new changes adds a bodySerializer1 that creates new URLSearchParams from the body object, and stringifies it, thus allowing requests to be sent with correct body objects.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@madewithkode madewithkode requested a review from a team as a code owner January 12, 2025 10:18
@madewithkode madewithkode self-assigned this Jan 12, 2025
@openverse-bot openverse-bot added 🧱 stack: frontend Related to the Nuxt frontend 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Jan 12, 2025
Copy link

Latest k6 run output1

     ✓ status was 200

     checks.........................: 100.00% ✓ 412      ✗ 0   
     data_received..................: 94 MB   389 kB/s
     data_sent......................: 54 kB   224 B/s
     http_req_blocked...............: avg=34.17µs  min=2.32µs   med=4.42µs   max=342.62µs p(90)=147.65µs p(95)=167.74µs
     http_req_connecting............: avg=20.84µs  min=0s       med=0s       max=285.62µs p(90)=98.02µs  p(95)=118.98µs
     http_req_duration..............: avg=159.8ms  min=18.1ms   med=114.99ms max=999.52ms p(90)=356.44ms p(95)=414.71ms
       { expected_response:true }...: avg=159.8ms  min=18.1ms   med=114.99ms max=999.52ms p(90)=356.44ms p(95)=414.71ms
   ✓ http_req_failed................: 0.00%   ✓ 0        ✗ 412 
     http_req_receiving.............: avg=155.11µs min=65.26µs  med=131.67µs max=569.09µs p(90)=240.32µs p(95)=313.94µs
     http_req_sending...............: avg=23.7µs   min=8.19µs   med=22.12µs  max=63.62µs  p(90)=36.92µs  p(95)=42.83µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=159.62ms min=17.96ms  med=114.82ms max=999.26ms p(90)=356.26ms p(95)=414.34ms
     http_reqs......................: 412     1.70933/s
     iteration_duration.............: avg=861.65ms min=418.11ms med=932.99ms max=1.71s    p(90)=1.12s    p(95)=1.5s    
     iterations.....................: 77      0.319462/s
     vus............................: 3       min=0      max=6 
     vus_max........................: 60      min=60     max=60

Footnotes

  1. This comment will automatically update with new output each time k6 runs for this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend
Projects
Status: 👀 Needs Review
Development

Successfully merging this pull request may close these issues.

Add bodySerializer and Accept header to @openverse/api-client to correctly authenticate with the API
2 participants