Fix logic inversion in error message

Co-authored-by: Pascal Birchler <[email protected]>
WordPress · Aug 22, 2024 · 561c018 · 561c018
1 parent 3a2448b
commit 561c018
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/plugins/optimization-detective/class-od-url-metric.php b/plugins/optimization-detective/class-od-url-metric.php
@@ -97,7 +97,7 @@ private function validate_data( array $data ): void {
 				esc_html(
 					sprintf(
 						/* translators: 1: current aspect ratio, 2: minimum aspect ratio, 3: maximum aspect ratio */
-						__( 'Viewport aspect ratio (%1$s) is in the accepted range of %2$s to %3$s.', 'optimization-detective' ),
+						__( 'Viewport aspect ratio (%1$s) is not in the accepted range of %2$s to %3$s.', 'optimization-detective' ),
 						$aspect_ratio,
 						$min_aspect_ratio,
 						$max_aspect_ratio

diff --git a/plugins/optimization-detective/detect.js b/plugins/optimization-detective/detect.js
@@ -202,7 +202,7 @@ export default async function detect( {
 	) {
 		if ( isDebug ) {
 			warn(
-				`Viewport aspect ratio (${ aspectRatio }) is in the accepted range of ${ minViewportAspectRatio } to ${ maxViewportAspectRatio }.`
+				`Viewport aspect ratio (${ aspectRatio }) is not in the accepted range of ${ minViewportAspectRatio } to ${ maxViewportAspectRatio }.`
 			);
 		}
 		return;

diff --git a/plugins/optimization-detective/tests/test-class-od-url-metric.php b/plugins/optimization-detective/tests/test-class-od-url-metric.php
@@ -101,7 +101,7 @@ public function data_provider(): array {
 					'timestamp' => microtime( true ),
 					'elements'  => array(),
 				),
-				'error' => 'Viewport aspect ratio (0.1) is in the accepted range of 0.4 to 2.5.',
+				'error' => 'Viewport aspect ratio (0.1) is not in the accepted range of 0.4 to 2.5.',
 			),
 			'viewport_aspect_ratio_too_large' => array(
 				'data'  => array(
-Original file line number
+Diff line change
@@ Expand Up / @@ -202,7 +202,7 @@ export default async function detect( { @@
     	) {
     		if ( isDebug ) {
     			warn(
-    				`Viewport aspect ratio (${ aspectRatio }) is in the accepted range of ${ minViewportAspectRatio } to ${ maxViewportAspectRatio }.`
+    				`Viewport aspect ratio (${ aspectRatio }) is not in the accepted range of ${ minViewportAspectRatio } to ${ maxViewportAspectRatio }.`
     			);
     		}
     		return;
@@ Expand Down @@