[TRY] Optimization Detective debug helper #1759
Conversation
swissspidy
added
[Type] Enhancement
| $processor->append_body_html( | ||
| <<<HTML | ||
| <button | ||
| class="od-debug-dot" | ||
| type="button" | ||
| popovertarget="od-debug-popover-$uuid" | ||
| popovertargetaction="toggle" | ||
| style="--anchor-name: --od-debug-dot-$uuid; position-anchor: --od-debug-element-$uuid;" | ||
| aria-details="od-debug-popover-$uuid" | ||
| > | ||
| $anchor_text | ||
| </button> | ||
| <div | ||
| id="od-debug-popover-$uuid" | ||
| popover | ||
| class="od-debug-popover" | ||
| style="position-anchor: --od-debug-dot-$uuid;" | ||
| > | ||
| $popover_text | ||
| </div> | ||
| HTML |
plugins/optimization-detective/class-optimization-detective-debug-tag-visitor.php
Outdated
Show resolved
Hide resolved
plugins/optimization-detective/class-optimization-detective-debug-tag-visitor.php
Outdated
Show resolved
Hide resolved
plugins/optimization-detective/class-optimization-detective-debug-tag-visitor.php
Outdated
Show resolved
Hide resolved
plugins/optimization-detective/class-optimization-detective-debug-tag-visitor.php
Outdated
Show resolved
Hide resolved
| 'items' => array( | ||
| 'type' => 'object', | ||
| 'required' => true, | ||
| 'properties' => array( |
There was a problem hiding this comment.
We'll want to include the LoAF data here at some point.
| 'group' => null, | ||
| 'title' => __( 'Optimization Detective', 'optimization-detective' ), | ||
| 'meta' => array( | ||
| 'onclick' => 'document.body.classList.toggle("od-debug");', |
There was a problem hiding this comment.
O invoker commands, where art thou?
| if ( ! od_can_optimize_response() ) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Since pages aren't optimized by default for users who can customize, this presents a dilemma. We'd really want to show data collected for end users who aren't logged-in, but as it stands right now only the URL Metrics collected from an admin user would be collected here, which again would normally be none.
Otherwise, URL Metrics are collected for logged-in users but they are stored discretely from those stored for logged-out users. See the user_logged_in "query var" added in the od_get_normalized_query_vars() function:
performance/plugins/optimization-detective/storage/data.php
Lines 66 to 86 in c446d8c
I'm not entirely happy with how I "abused" the query vars in this way.
| $slug = od_get_url_metrics_slug( od_get_normalized_query_vars() ); | ||
| $post = OD_URL_Metrics_Post_Type::get_post( $slug ); | ||
|
|
||
| global $wp_the_query; | ||
|
|
||
| $tag_visitor_registry = new OD_Tag_Visitor_Registry(); | ||
|
|
||
| $current_etag = od_get_current_url_metrics_etag( $tag_visitor_registry, $wp_the_query, od_get_current_theme_template() ); | ||
| $group_collection = new OD_URL_Metric_Group_Collection( | ||
| $post instanceof WP_Post ? OD_URL_Metrics_Post_Type::get_url_metrics_from_post( $post ) : array(), | ||
| $current_etag, | ||
| od_get_breakpoint_max_widths(), | ||
| od_get_url_metrics_breakpoint_sample_size(), | ||
| od_get_url_metric_freshness_ttl() | ||
| ); |
There was a problem hiding this comment.
Since this code is duplicated with what is located in od_optimize_template_output_buffer(), maybe we should factor that out into a helper function to return the $group_collection.
Co-authored-by: Weston Ruter <[email protected]>
swissspidy
added
the
no milestone
Summary
Fixes #1736
Idea: add a "dot" on relevant elements (e.g. LCP elements). Click on the dot to learn more about the element.
Relevant technical choices