Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRY] Optimization Detective debug helper #1759

Draft
wants to merge 20 commits into
base: trunk
Choose a base branch
from

Conversation

swissspidy
Copy link
Member

Summary

Fixes #1736

Idea: add a "dot" on relevant elements (e.g. LCP elements). Click on the dot to learn more about the element.

Screenshot 2024-12-18 at 21 13 55

Relevant technical choices

  • Allows loading web-vitals attribution build

@swissspidy swissspidy added [Type] Enhancement A suggestion for improvement of an existing feature [Plugin] Optimization Detective Issues for the Optimization Detective plugin labels Dec 18, 2024
@swissspidy swissspidy added the no milestone PRs that do not have a defined milestone for release label Dec 19, 2024
@swissspidy
Copy link
Member Author

With fresh eyes I was able to fix the anchor positioning and styling a bit. This looks much better now:

Screen.Recording.2025-01-10.at.15.42.34.mov

Of course it needs a lot of tidying up still, but it seems to more or less work.

Now we just need to figure out where to put all of this code. don't necessarily like putting it into its own GitHub repo where it's not easily discoverable.


Aside:

There is one test failure now:

1) Test_OD_URL_Metric::test_get_json_schema
root/inpData
Failed asserting that false is true.

🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no milestone PRs that do not have a defined milestone for release [Plugin] Optimization Detective Issues for the Optimization Detective plugin [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explore opportunities to use Optimization Detective to identify INP problems
2 participants