Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move image-loading-optimization from module to plugin #1040

Merged
merged 309 commits into from
Mar 11, 2024
Merged

Move image-loading-optimization from module to plugin #1040

merged 309 commits into from
Mar 11, 2024

Conversation

westonruter
Copy link
Member

@westonruter westonruter commented Mar 9, 2024 •
edited
Loading

This PR merges trunk into feature/image-loading-optimization and then moves the feature from a module to a plugin. The commits beyond the merge from trunk (07c1291) are 07c1291...28bbb70.

Previously:

Subsequent PR will rename to Optimization Detective.

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

felixarntz and others added 30 commits January 17, 2024 10:29
@felixarntz
Use more precise array doc syntax in more places.
3c6aec2
@felixarntz
Limit maximum width instead of using br.
e24b010
@felixarntz
Use better phrased description for REST API too.
da0b883
@felixarntz
More defensive coding when accessing array keys.
d490f93
@felixarntz
Merge pull request #939 from WordPress/add/speculation-rules-settings
13bc154 
Add Speculation Rules settings and UI
@joemcgill
Auto-sizes: Disallow direct file access
35e5fbf
@felixarntz
Move Speculation Rules to new location as purely a standalone plugin.
f1e9ee3
@joemcgill
Merge pull request #945 from WordPress/fix/auto-sizes-direct-load
3cb88e5 
Auto-sizes: Disallow direct file access
@mukeshpanchal27
Add plugins folder
aa2437d
@mukeshpanchal27
ignore plugins folder
c366c91
@mukeshpanchal27
Restructure the plugins.json file
2ebdda4
@mukeshpanchal27
Update build-plugins script
c59f9f9
@mukeshpanchal27
Update test-plugins script
5ab7268
@mukeshpanchal27
Update Deploy standalone plugins workflow
177b2e9
@mukeshpanchal27
Add plugins in tooling
c55b3e6
@mukeshpanchal27
Merge branch 'feature/modules-to-plugins' into add/934-plugins-folder
7c3d1d1
@mukeshpanchal27 @swissspidy
Apply suggestions from code review
7df015d 
Co-authored-by: Pascal Birchler <[email protected]>
@mukeshpanchal27
Update variable names
643d78b
@mukeshpanchal27
Remove the temporary changes
b0bad91
@felixarntz
Merge pull request #948 from WordPress/add/934-plugins-folder
16fda54 
Introduce plugins folder for standalone plugins
@jeremyroman
Escape path prefix and restrict it to be a pathname in Speculation Rules
34af17b 
On unusual deployment setups (but notably WordPress Playground), the
path prefix might contain one of the URL pattern special characters,
such as :.

Escape these characters in the path prefix, and since some of these also
confuse the shorthand constructor string syntax, use the longhand syntax
which specifies that the presence of a : here does not indicate a
protocol/scheme.
@westonruter
Force HTML5 script theme support when printing JSON script
06b6d30
@westonruter
Negate condition
f031c21
@westonruter
Add tests for valid JSON workaround
13d4546
@westonruter
Add ticket reference
e9924bc
@westonruter
Limit workaround to WP 6.4
804a49b
@jeremyroman
Use braces to deal with component confusion issue instead (and other …
3c8d640 
…code review comments).
@jeremyroman @westonruter
Use addcslashes
3a16b14 
Co-authored-by: Weston Ruter <[email protected]>
@mukeshpanchal27
Plugin test suite
dbe1a99
@mukeshpanchal27
Add test file
cef64a3
joemcgill and others added 12 commits March 7, 2024 08:17
@joemcgill @mukeshpanchal27
Remove filetype specific rule
641f094 
Co-authored-by: Mukesh Panchal <[email protected]>
@joemcgill
Merge branch 'trunk' into update/editorconfig-json-add-newline
5682484
@mukeshpanchal27
Merge pull request #1034 from WordPress/update/editorconfig-json-add-…
38f584e 
…newline

Update the .editorconfig to add a new line for json files
@felixarntz
Add changelog entry to WebP Uploads readme.
c1dab55
@mukeshpanchal27
Merge pull request #1038 from WordPress/update/webp-uploads-changelog
06d6ffe 
Add changelog entry for #1036 to WebP Uploads readme
@westonruter
Merge remote-tracking branch 'origin/trunk' into merge/trunk-into-ima…
07c1291 
…ge-loading-optimization
@westonruter
Move image-loading-optimization to from modules to plugins
6bcd109
@westonruter
Update module to be plugin
679a5fe
@westonruter
Replace performance-lab with image-loading-optimization
f533cd3
@westonruter
Add silence is golden exits
ad3aa3d
@westonruter
Add phpcs.xml.dist for ILO plugin
3923d1e
@westonruter
Add initial readme
4137aea
@westonruter westonruter added [Type] Enhancement A suggestion for improvement of an existing feature [Focus] Images no milestone PRs that do not have a defined milestone for release [Plugin] Optimization Detective Issues for the Optimization Detective plugin labels Mar 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 9, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @jeremyroman.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: jeremyroman.

Co-authored-by: felixarntz <[email protected]>
Co-authored-by: joemcgill <[email protected]>
Co-authored-by: mukeshpanchal27 <[email protected]>
Co-authored-by: westonruter <[email protected]>
Co-authored-by: adamsilverstein <[email protected]>
Co-authored-by: swissspidy <[email protected]>
Co-authored-by: desrosj <[email protected]>
Co-authored-by: thelovekesh <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@westonruter westonruter mentioned this pull request Mar 9, 2024
Merged
3 tasks
mukeshpanchal27
mukeshpanchal27 approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Why do we need an additional build step as seen in 28bbb70? We don't seem to have it in the trunk. Just asking to clarify.

@westonruter
Copy link
Member Author

Why do we need an additional build step as seen in 28bbb70? We don't seem to have it in the trunk. Just asking to clarify.

Good question. Unlike trunk, the Optimization Detective plugin includes JavaScript assets. This asset build process isn't currently needed in trunk, but it is needed by this plugin and as it will by Web Worker Offloading (#556) as well.

@westonruter westonruter merged commit fac7213 into feature/image-loading-optimization Mar 11, 2024
41 checks passed
@westonruter westonruter deleted the update/ilo-module-to-plugin branch March 11, 2024 16:27
@felixarntz felixarntz mentioned this pull request Aug 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 approved these changes

@pbearne pbearne Awaiting requested review from pbearne pbearne is a code owner

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

@adamsilverstein adamsilverstein Awaiting requested review from adamsilverstein adamsilverstein is a code owner

@felixarntz felixarntz Awaiting requested review from felixarntz felixarntz is a code owner

Assignees
No one assigned
Labels
no milestone PRs that do not have a defined milestone for release [Plugin] Optimization Detective Issues for the Optimization Detective plugin [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.