-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Image Loading Optimization module #875
Add Image Loading Optimization module #875
Conversation
@westonruter Can you please update this to be against a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@westonruter This looks good, just one point of feedback (plus let's change the base branch before merge to a new feature branch).
@felixarntz I just now pushed up a new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @westonruter!
795a92f
into
feature/image-loading-optimization
Just noted that this PR and #878 are annotated with the PL 2.8.0 release, but it's not actually milestoned for a release yet since we are working in the feature branch towards a working version before moving ahead with merging into |
Summary
Add scaffolding for new Image Loading Module with some key basic functionality, namely the output buffering of template renders and the introduction of a filter for that buffered output.
Fixes #805
Relevant technical choices
When the module is active, the output buffering UI elements for Server Timing are omitted since the Image Loading Optimization module always does output buffering. Similarly, when the module is running, Server Timing will wait to send the header at the end of the new
perflab_template_output_buffer
filter.Checklist
[Focus]
orInfrastructure
label.[Type]
label.no milestone
label.