Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitize metric name for Server-Timing header #957

Merged
merged 4 commits into from
Jan 29, 2024
Merged

Sanitize metric name for Server-Timing header #957

merged 4 commits into from
Jan 29, 2024

Conversation

swissspidy
Copy link
Member

@swissspidy swissspidy commented Jan 29, 2024 •
edited
Loading

Summary

Ensures metric name does not contain invalid characters such as "/".

Fixes #955

Relevant technical choices

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@swissspidy swissspidy added [Type] Bug An existing feature is broken Infrastructure Issues for the overall performance plugin infrastructure labels Jan 29, 2024
@swissspidy swissspidy added this to the PL Plugin 2.9.0 milestone Jan 29, 2024
@swissspidy swissspidy changed the title Sanitize slashes for Server-Timing header Sanitize metric name for Server-Timing header Jan 29, 2024
adamsilverstein
adamsilverstein approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@adamsilverstein adamsilverstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@swissspidy swissspidy merged commit 3a366e3 into trunk Jan 29, 2024
13 checks passed
@swissspidy swissspidy deleted the fix/955-slashes branch January 29, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamsilverstein adamsilverstein adamsilverstein approved these changes

@westonruter westonruter westonruter approved these changes

@joemcgill joemcgill Awaiting requested review from joemcgill

@mukeshpanchal27 mukeshpanchal27 Awaiting requested review from mukeshpanchal27

Assignees
No one assigned
Labels
Infrastructure Issues for the overall performance plugin infrastructure [Type] Bug An existing feature is broken
Projects
None yet
Milestone
PL Plugin 2.9.0
Development

Successfully merging this pull request may close these issues.

Server-Timing: Slashes in metric name not working
3 participants
@swissspidy @westonruter @adamsilverstein