Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PHPUnit and PHPCS config file path from composer scripts #995

Merged
merged 5 commits into from
Feb 16, 2024

Conversation

thelovekesh
Copy link
Member

Summary

Previously: #989

Remove hard-coded config file paths to let the tools decide which config to load on the user machine. With this, the following tools will be able to:

  • PHPCS will be able to prioritize phpcs.xml over phpcs.xml.dist if present locally.
  • PHPUnit will be able to prioritize phpunit.xml over phpunit.xml.dist if present locally.

Relevant technical choices

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@thelovekesh thelovekesh added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release labels Feb 16, 2024
Copy link

github-actions bot commented Feb 16, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: thelovekesh <[email protected]>
Co-authored-by: westonruter <[email protected]>
Co-authored-by: swissspidy <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

.gitignore Outdated Show resolved Hide resolved
Co-authored-by: Weston Ruter <[email protected]>
@westonruter westonruter merged commit 71c6c0e into trunk Feb 16, 2024
29 checks passed
@westonruter westonruter deleted the update/phpunit-composer-script branch February 16, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants