Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wp-now: WebContainer support fixes #221

Merged
merged 1 commit into from
Apr 15, 2024
Merged

wp-now: WebContainer support fixes #221

merged 1 commit into from
Apr 15, 2024

Conversation

kirjavascript
Copy link
Contributor

Improvements to #150 with fixes related to updates for wp-now in WebContainer

Can be retargetting to trunk if you want to close the other PR

Testing Instructions

Visit https://stackblitz.com/edit/node and run

npx @wp-now/wp-now@some-version start

WP-Now should load in your browser

@adamziel adamziel changed the base branch from webcontainers-support to trunk April 11, 2024 22:54
Copy link
Collaborator

@adamziel adamziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I changed the base to trunk and there's just a package.json conflict to fix. cc @sejas

@kirjavascript
Copy link
Contributor Author

I made a bit of a mess with the history when updating the branch, but it should be good to go now.

@adamziel adamziel merged commit 3a3a4e1 into WordPress:trunk Apr 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants