changed to ERROR_EXTRA as suggested

WordPress · Oct 18, 2024 · 57950b1 · 57950b1
1 parent 16a33d1
commit 57950b1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/includes/CLI/Plugin_Check_Command.php b/includes/CLI/Plugin_Check_Command.php
@@ -686,9 +686,8 @@ private function get_filtered_results_by_severity( $results, $error_severity, $w
 			if ( 'ERROR' === $item['type'] && $item['severity'] >= $error_severity ) {
 				$errors[] = $item;
 			} elseif ( $include_low_severity_errors && 'ERROR' === $item['type'] && $item['severity'] < $error_severity ) {
-				$item['type']     = 'WARNING';
-				$item['severity'] = 10;
-				$warnings[]       = $item;
+				$item['type'] = 'ERROR_EXTRA';
+				$warnings[]   = $item;
 			} elseif ( 'WARNING' === $item['type'] && $item['severity'] >= $warning_severity ) {
 				$warnings[] = $item;
 			}

diff --git a/tests/behat/features/plugin-check-severity.feature b/tests/behat/features/plugin-check-severity.feature
@@ -199,11 +199,11 @@ Feature: Test that the severity level in plugin check works.
       """
     And STDOUT should contain:
       """
-      default_readme_text,WARNING,7
+      WordPress.WP.AlternativeFunctions.rand_mt_rand,ERROR_EXTRA,5
       """
     And STDOUT should contain:
       """
-      upgrade_notice_limit,WARNING,10
+      WordPress.Security.EscapeOutput.OutputNotEscaped,ERROR_EXTRA,5
       """
 
     When I run the WP-CLI command `plugin check foo-bar-wp --format=csv --fields=code,type,severity --severity=10`