Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove is_plugin_check method from Abstract_Check_Runner Class #235

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

mukeshpanchal27
Copy link
Member

During the QA testing process for the repository hosted at #194 (comment), we have identified a specific error. The code in question involves the usage of abstract static functions in PHP, which is considered discouraged. It has come to our attention that the Check_Runner interface already declares this function, making its presence as an abstract method in Abstract_Check_Runner unnecessary.

As a result, we propose the removal of the aforementioned method from the Abstract_Check_Runner class to adhere to best practices and improve the codebase's maintainability and clarity.

CLI: Strict Standards: Static function WordPress\Plugin_Check\Checker\Abstract_Check_Runner::is_plugin_check() should not be abstract in /var/www/html/wp-content/plugins/plugin-check/includes/Checker/Abstract_Check_Runner.php on line 102

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.

@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review July 24, 2023 08:57
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mukeshpanchal27
Copy link
Member Author

@joemcgill or @swissspidy, could either of you review and approve this so that we can merge it when you have few moment please? Thank you!

@swissspidy swissspidy merged commit 5b7992c into trunk Jul 26, 2023
13 checks passed
@swissspidy swissspidy deleted the fix/remove-method-from-abstract-check-runner branch July 26, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants