Fix errors detected by Plugin Checker #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@felixarntz @joemcgill In d7012f4 i added ignore for warning |
swissspidy
reviewed
Aug 1, 2023
swissspidy
reviewed
Aug 1, 2023
joemcgill
reviewed
Aug 1, 2023
felixarntz
reviewed
Aug 1, 2023
There was a problem hiding this comment.
@mukeshpanchal27 Just a minor suggestion to clarify the comment about nonce verification, since it should happen, but it does already happen elsewhere (in Admin_AJAX class).
Other than that, looks good except for @joemcgill's existing point.
Co-authored-by: Felix Arntz <[email protected]>
joemcgill
approved these changes
Aug 2, 2023
felixarntz
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses several issues detected by the Plugin Checker when validating the plugin itself. The changes in this PR aim to resolve potential problems and improve overall code quality.
Please refer to #224 (comment) for a detailed list of errors identified by the Plugin Checker during the validation process.
Checklist: