Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not go for next check if Stable Tag value is trunk #668

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Do not go for next check if Stable Tag value is trunk #668

merged 2 commits into from
Sep 26, 2024

Conversation

ernilambar
Copy link
Member

Fixes #667

@ernilambar ernilambar force-pushed the 667-redundant-test-for-stable-tag branch from cbccc08 to 2918e64 Compare September 26, 2024 06:20
@ernilambar ernilambar force-pushed the 667-redundant-test-for-stable-tag branch from 2918e64 to 0dd3050 Compare September 26, 2024 06:21
@ernilambar ernilambar marked this pull request as ready for review September 26, 2024 06:35
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 26, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <[email protected]>
Co-authored-by: swissspidy <[email protected]>
Co-authored-by: davidperezgar <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ernilambar ernilambar added [Type] Enhancement A suggestion for improvement of an existing feature [Team] Plugin Review Issues owned by Plugin Review Team labels Sep 26, 2024
@ernilambar ernilambar added this to the 1.2.0 milestone Sep 26, 2024
@ernilambar ernilambar merged commit b79f658 into trunk Sep 26, 2024
32 checks passed
@ernilambar ernilambar deleted the 667-redundant-test-for-stable-tag branch September 26, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidperezgar davidperezgar davidperezgar approved these changes

@swissspidy swissspidy swissspidy approved these changes

@barrykooij barrykooij Awaiting requested review from barrykooij barrykooij is a code owner

@frantorres frantorres Awaiting requested review from frantorres frantorres is a code owner

Assignees
No one assigned
Labels
[Team] Plugin Review Issues owned by Plugin Review Team [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Redundant test for Stable Tag when value is trunk
3 participants
@ernilambar @swissspidy @davidperezgar