Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes SPDX warning #701

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Fixes SPDX warning #701

merged 1 commit into from
Oct 7, 2024

Conversation

davidperezgar
Copy link
Member

Fixes #698

@davidperezgar davidperezgar linked an issue Oct 6, 2024 that may be closed by this pull request
Checker seems to be returning invalid license warning #698
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 6, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: davidperezgar <[email protected]>
Co-authored-by: ernilambar <[email protected]>
Co-authored-by: felixarntz <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

felixarntz
felixarntz approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davidperezgar!

One additional suggestion: Further up in the Plugin_Readme_Check.php file, maybe we should add another string (or later)? I've seen several plugins use that, i.e. including parentheses.

@davidperezgar davidperezgar merged commit 9e4cd46 into trunk Oct 7, 2024
30 checks passed
@davidperezgar davidperezgar deleted the 698-checker-seems-to-be-returning-invalid-license-warning branch October 7, 2024 20:09
@davidperezgar
Copy link
Member Author

Ok, I didn't see it. Yes. Let's do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixarntz felixarntz felixarntz approved these changes

@ernilambar ernilambar ernilambar approved these changes

@barrykooij barrykooij Awaiting requested review from barrykooij barrykooij is a code owner

@frantorres frantorres Awaiting requested review from frantorres frantorres is a code owner

@swissspidy swissspidy Awaiting requested review from swissspidy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Checker seems to be returning invalid license warning
3 participants
@davidperezgar @ernilambar @felixarntz