Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't flag Apache license #716

Merged
merged 1 commit into from
Oct 12, 2024
Merged

Don't flag Apache license #716

merged 1 commit into from
Oct 12, 2024

Conversation

swissspidy
Copy link
Member

Apache 2.0 is a GPL compatible license and there are many Apache 2.0 licensed plugins in the repository. It should not be flagged by PCP.

@swissspidy swissspidy added [Type] Bug An existing feature is broken Checks Audit/test of the particular part of the plugin labels Oct 11, 2024
@swissspidy swissspidy added this to the 1.3.0 milestone Oct 11, 2024
@swissspidy swissspidy requested a review from felixarntz October 11, 2024 17:24
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 11, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: swissspidy <[email protected]>
Co-authored-by: felixarntz <[email protected]>
Co-authored-by: davidperezgar <[email protected]>
Co-authored-by: ernilambar <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

felixarntz
felixarntz approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@ernilambar
Copy link
Member

I have found few instances of MPL 2.0 also in few plugins. https://www.gnu.org/licenses/license-list.en.html#MPL-2.0

davidperezgar
davidperezgar approved these changes Oct 12, 2024
View reviewed changes
Copy link
Member

@davidperezgar davidperezgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Apache is allowed.

@davidperezgar
Copy link
Member

@ernilambar we would need to ask in the Team if it's allowed. We're not lawyers, so it would be fine if someone confirms that.

@swissspidy swissspidy merged commit fdd8002 into trunk Oct 12, 2024
31 of 32 checks passed
@swissspidy swissspidy deleted the fix/apache branch October 12, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidperezgar davidperezgar davidperezgar approved these changes

@felixarntz felixarntz felixarntz approved these changes

@barrykooij barrykooij Awaiting requested review from barrykooij barrykooij is a code owner

@ernilambar ernilambar Awaiting requested review from ernilambar ernilambar is a code owner

@frantorres frantorres Awaiting requested review from frantorres frantorres is a code owner

Assignees
No one assigned
Labels
Checks Audit/test of the particular part of the plugin [Type] Bug An existing feature is broken
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@swissspidy @ernilambar @davidperezgar @felixarntz