Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new image functions check #721

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Add new image functions check #721

merged 1 commit into from
Oct 15, 2024

Conversation

swissspidy
Copy link
Member

Checks and warns against the usage of image HTML in templates. Developers are encouraged to use image functions such as wp_get_attachment_image that generate image HTML in templates

Fixes #26

@swissspidy swissspidy added [Type] Enhancement A suggestion for improvement of an existing feature Checks Audit/test of the particular part of the plugin labels Oct 15, 2024
@swissspidy swissspidy force-pushed the fix/26-image-functions branch 2 times, most recently from e957d59 to 8c2b1e7 Compare October 15, 2024 13:10
@swissspidy swissspidy force-pushed the fix/26-image-functions branch from 8c2b1e7 to e841899 Compare October 15, 2024 13:14
@swissspidy swissspidy marked this pull request as ready for review October 15, 2024 13:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 15, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: swissspidy <[email protected]>
Co-authored-by: felixarntz <[email protected]>
Co-authored-by: davidperezgar <[email protected]>
Co-authored-by: mehulkaklotar <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

felixarntz
felixarntz approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@swissspidy Thanks for implementing this, looks great!

includes/Checker/Checks/Performance/Image_Functions_Check.php Show resolved Hide resolved
@swissspidy swissspidy added this to the 1.3.0 milestone Oct 15, 2024
@swissspidy swissspidy merged commit 8ca484a into trunk Oct 15, 2024
33 checks passed
@swissspidy swissspidy deleted the fix/26-image-functions branch October 15, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidperezgar davidperezgar davidperezgar approved these changes

@felixarntz felixarntz felixarntz approved these changes

@adamsilverstein adamsilverstein Awaiting requested review from adamsilverstein adamsilverstein is a code owner

@joemcgill joemcgill Awaiting requested review from joemcgill joemcgill is a code owner

@mukeshpanchal27 mukeshpanchal27 Awaiting requested review from mukeshpanchal27 mukeshpanchal27 is a code owner

@westonruter westonruter Awaiting requested review from westonruter westonruter is a code owner

Assignees
No one assigned
Labels
Checks Audit/test of the particular part of the plugin [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

Create Image_Functions_Usage_Check
3 participants
@swissspidy @felixarntz @davidperezgar