Fix addon checks not being executed when running runtime checks

[felixarntz]

This is a child PR of #749. Please merge that one first.

Fixes #607.

As noted prior, despite our various fixes related to e.g. #597, addon runtime checks still don't work as of today. This PR aims to fix that.

It looks like the underlying problem is that the Default_Check_Repository runs the wp_plugin_check_checks filter too early when any runtime checks are being run. Now that I noticed it, it seems like an obvious oversight, but was kind of hard to spot 😅

To address this problem, we simply need to ensure the filter is run again after plugins have been loaded.

For the scenario where the Default_Check_Repository is instantiated when plugins are already loaded, no change is needed, in this case we can set a flag that the checks are "fully initialized" from the start.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: felixarntz <[email protected]>
Co-authored-by: swissspidy <[email protected]>
Co-authored-by: ernilambar <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[swissspidy]

This is a child PR of #749. Please merge that one first.

Wanna rebase to make that more clear?

[felixarntz]

This is a child PR of #749. Please merge that one first.

Wanna rebase to make that more clear?

Yes, I just had this open against trunk so that all the tests run and I can verify they pass. Just changed it back to the other branch.

Here you can see the Behat tests passing with the latest state of this PR, including all the ones that used to be commented out: https://github.com/WordPress/plugin-check/actions/runs/11525465349

[swissspidy]

Nice!