Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement gherkin linter in GH action #754

Merged
merged 5 commits into from
Oct 27, 2024
Merged

Conversation

ernilambar
Copy link
Member

@ernilambar ernilambar commented Oct 27, 2024

Add Gherkin linter

  • Add .gherkin-lintrc file
  • Exclude this file in distignore and gitattributes
  • Add gherkin-lint.yml action config file

@ernilambar ernilambar force-pushed the implement-gherkin-linter branch 7 times, most recently from 4c24d6d to 9f09e94 Compare October 27, 2024 08:07
@ernilambar ernilambar added the Infrastructure Issues for the overall plugin infrastructure label Oct 27, 2024
@ernilambar ernilambar marked this pull request as ready for review October 27, 2024 08:23
Copy link

github-actions bot commented Oct 27, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <[email protected]>
Co-authored-by: swissspidy <[email protected]>
Co-authored-by: davidperezgar <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ernilambar
Copy link
Member Author

I could not find rule to enforce indentation for following:

Then STDOUT should contain:
"""
Success: Checks complete. No errors found.
"""

Generally we write like this:

Then STDOUT should contain:
  """
  Success: Checks complete. No errors found.
  """

@ernilambar ernilambar added this to the 1.3.0 milestone Oct 27, 2024
@ernilambar ernilambar merged commit 02aeb3e into trunk Oct 27, 2024
32 checks passed
@ernilambar ernilambar deleted the implement-gherkin-linter branch October 27, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issues for the overall plugin infrastructure Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants