Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force slug in wp cli command to ensure that it get's the correct one by default #780

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Force slug in wp cli command to ensure that it get's the correct one by default #780

wants to merge 2 commits into from

Conversation

davidperezgar
Copy link
Member

Fixes #774

@davidperezgar davidperezgar linked an issue Nov 10, 2024 that may be closed by this pull request
[Bug] TextDomainMismatch if checking a plugin via path #774
Open
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 10, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: davidperezgar <[email protected]>
Co-authored-by: ernilambar <[email protected]>
Co-authored-by: swissspidy <[email protected]>
Co-authored-by: hirasso <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@davidperezgar davidperezgar added this to the 1.3.0 milestone Nov 10, 2024
@ernilambar
Copy link
Member

@davidperezgar #774 This issue is about incorrect plugin slug calculation when checked like /wp-content/plugins/my-plugin/my-plugin. I am not getting how this solves the mentioned issue. Am I missing something?

@ernilambar ernilambar removed this from the 1.3.0 milestone Nov 11, 2024
@ernilambar
Copy link
Member

Removing from 1.3 milestone. We can push this for 1.4 after detailed discussion.

@davidperezgar
Copy link
Member Author

My proposal is to calculate the default slug before launching the checks. If slug is empty, then it should calc the slug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy Awaiting requested review from swissspidy

@ernilambar ernilambar Awaiting requested review from ernilambar

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] TextDomainMismatch if checking a plugin via path
2 participants
@davidperezgar @ernilambar