-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify types #85
Open
psrpinto
wants to merge
34
commits into
trunk
Choose a base branch
from
simplify-types
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Simplify types #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psrpinto
force-pushed
the
simplify-types
branch
from
October 23, 2024 15:30
234845d
to
557632a
Compare
psrpinto
force-pushed
the
simplify-types
branch
from
October 23, 2024 16:20
557632a
to
f0e1288
Compare
psrpinto
force-pushed
the
simplify-types
branch
from
October 23, 2024 16:58
45663f3
to
8e36873
Compare
psrpinto
force-pushed
the
simplify-types
branch
from
October 24, 2024 15:13
fdd91ac
to
0495b91
Compare
psrpinto
force-pushed
the
simplify-types
branch
from
October 24, 2024 16:59
3b7d422
to
98983c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the type definitions quite a bit, and also other aspects of the frontend code, so that it's easier to then implement the
Navigation
type.Thanks @ashfame for providing feedback on the types being too complicated (you were definitely right, there were a lot of things wrong), and for discussing things prior and during development of the PR.
There are no user-facing chances here, just cleaning things up in preparation for importing navigation.
Summary of changes
Post
has been renamed toSubject
. It represents the piece of content being imported, e.g Blog post, product, header, footer, etc. This helps with differentiating between the "liberated post" and the "transformed post". In short, subject = liberated post.