Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify types #85

Open
wants to merge 34 commits into
base: trunk
Choose a base branch
from
Open

Simplify types #85

wants to merge 34 commits into from

Conversation

psrpinto
Copy link
Member

@psrpinto psrpinto commented Oct 23, 2024

I would recommend reviewing comit-by-commit, there's a lot of commits but they should be easy to understand on their own.

This PR simplifies the type definitions quite a bit, and also other aspects of the frontend code, so that it's easier to then implement the Navigation type.

Thanks @ashfame for providing feedback on the types being too complicated (you were definitely right, there were a lot of things wrong), and for discussing things prior and during development of the PR.

There are no user-facing chances here, just cleaning things up in preparation for importing navigation.

Summary of changes

  • Post has been renamed to Subject. It represents the piece of content being imported, e.g Blog post, product, header, footer, etc. This helps with differentiating between the "liberated post" and the "transformed post". In short, subject = liberated post.
  • The type definitions have been simplified quite a bit.
  • Moved things around, renamed files.

@psrpinto psrpinto self-assigned this Oct 23, 2024
@psrpinto psrpinto marked this pull request as ready for review October 25, 2024 11:10
@psrpinto psrpinto requested a review from ashfame October 25, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant