This repository has been archived by the owner on Jan 15, 2019. It is now read-only.
Add sizes
attribute for responsive images markup
#411
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #50.
Prototype. Currently only works properly for "regular" width images.
Notes:
$GLOBALS['block_width']
section needs work as the theme uses fluid widths for all images on wider screens. Current values are effectively random.sizes
attributes foralignwide
andalignfull
images we need a way of knowing, from within thewp_calculate_image_sizes
filter, what the width display setting is for the current image. At present it is only defined in a class on the parent<figure>
element which to my knowledge is inaccessible from the filter.Works as prototype for testing of Gutenberg issue 6177.
cc @azaozz
Todo:
sizes
attributes foralignwide
andalignfull
sizes
attribute for featured images