Skip to content
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.

Remove hidden overflow from site-header #724

Closed
wants to merge 1 commit into from

Conversation

allancole
Copy link
Collaborator

Before:
screen shot 2018-12-09 at 2 49 32 pm

After:
image

- Prevents long sub-menus from getting truncated by the header height
@allancole allancole added bug Something isn't working needs testing labels Dec 10, 2018
@allancole allancole added this to the 5.0.1 milestone Dec 10, 2018
@allancole allancole requested a review from kjellr December 10, 2018 21:36
Copy link
Collaborator

@kjellr kjellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed this works for me. 👍

screen shot 2018-12-11 at 10 23 18 am

@LittleBigThing
Copy link

Hi,

@kjellr and @allancole: This might be trickier than it looks. This overflow: hidden was introduced in #450 to ensure that the background image is not visible outside of the header. Removing it seems to break things in Edge and IE11.

I would have to look into this in more detail to find a solution for all browsers... any ideas?

@kjellr
Copy link
Collaborator

kjellr commented Dec 17, 2018

Thanks, @LittleBigThing — I'll remove the approved for merge label until we double check that.

@kjellr
Copy link
Collaborator

kjellr commented Jan 10, 2019

@allancole — As per @LittleBigThing's notes above, this PR still had issues in IE, so I'm not going to migrate it over to Trac. The related issue is over here now:

https://core.trac.wordpress.org/ticket/45901

Let's follow up in the new thread moving forward. Thanks!

@kjellr kjellr closed this Jan 10, 2019
@kjellr kjellr deleted the fix/site-header-overflow branch January 14, 2019 17:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants