Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events: Add organize page. #1123

Merged
merged 6 commits into from
Dec 4, 2023
Merged

Events: Add organize page. #1123

merged 6 commits into from
Dec 4, 2023

Conversation

StevenDufresne
Copy link
Contributor

This PR implement the organize event page for events.wordpress.org.

Design:
https://www.figma.com/file/jdMk5ssz2Av7KFfEaeK7de/Events?node-id=1617%3A13490&mode=dev

Screenshots

Mobile Desktop
events wordpress test_organize-an-event_(Samsung Galaxy S8+) events wordpress test_organize-an-event_

* `theme.json`. I'm assuming that's a bug somewhere, but haven't tracked it down. This is a hack to make the
* content width usable until that bug is resolved.
*/
max-width: var( --wp--custom--layout--content-size ) !important;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This stopped me from using Gutenberg's "content/wide" settings for group blocks which I've used on the organize page to constrain the width.

I could have alternatively set --wp--custom--layout--content-size: 1120px in the body above but it isn't clear to me yet that 1120px is the content width for this theme.

After removing this, I didn't see any defects on other pages.

@StevenDufresne StevenDufresne merged commit 5653fe3 into production Dec 4, 2023
3 checks passed
@StevenDufresne StevenDufresne deleted the add/organize-page branch December 4, 2023 03:28
@iandunn iandunn added this to the Events: Promotion milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants