Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Events: Use a showcase like approach for the events list/archive #1124

Merged
merged 30 commits into from
Dec 6, 2023
Merged

Events: Use a showcase like approach for the events list/archive #1124

Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
44371c8
Try using a php block that queries.
StevenDufresne Dec 2, 2023
1a5adca
Example query filtering.
StevenDufresne Dec 2, 2023
a43b837
add block build script.
StevenDufresne Dec 3, 2023
d568afe
Add the patterns
StevenDufresne Dec 4, 2023
cf3a3f4
Hook in another filter.
StevenDufresne Dec 4, 2023
12b7c06
Rename template.
StevenDufresne Dec 4, 2023
29f8205
Some minor updates.
StevenDufresne Dec 4, 2023
c73ed57
Add the month filter
StevenDufresne Dec 4, 2023
9cc0b23
Add in Past Events template
iandunn Dec 4, 2023
5b413d4
update menu links
iandunn Dec 5, 2023
8404ff7
pass filter values to map block
iandunn Dec 5, 2023
5819e91
Add map block. Isn't yet connected to country list.
StevenDufresne Dec 5, 2023
e636d34
Update copy.
StevenDufresne Dec 5, 2023
3e7d9c2
Harmonize spacing.
StevenDufresne Dec 5, 2023
9662871
Make font size smaller for past events.
StevenDufresne Dec 5, 2023
1ee70b1
Update post title spacing.
StevenDufresne Dec 5, 2023
76c027c
Update search layout.
StevenDufresne Dec 5, 2023
55b279c
fix upcoming spacing.
StevenDufresne Dec 5, 2023
55b4e41
Update the filters to show the item count on archives.
StevenDufresne Dec 5, 2023
7b10fbb
Fix the template widths.
StevenDufresne Dec 5, 2023
d3db670
Update event list UI.
StevenDufresne Dec 5, 2023
c26787d
Update the menu text based on designs.
StevenDufresne Dec 5, 2023
855fa57
combine build/watch scripts for convenience
iandunn Dec 5, 2023
0889f6f
use get_events for filtering and caching
iandunn Dec 5, 2023
303e77f
add missing template part
iandunn Dec 5, 2023
0de639a
update upcoming events slug
iandunn Dec 5, 2023
b0c2278
add country filter values
iandunn Dec 5, 2023
9908d41
add all months
iandunn Dec 5, 2023
8796cbb
schedule crons to prime cache
iandunn Dec 6, 2023
47fdebd
apply coding standards
iandunn Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion public_html/wp-content/themes/wporg-events-2023/patterns/front-cover.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
<!-- wp:column {"width":"33.33%","fontSize":"medium","fontFamily":"eb-garamond"} -->
<div class="wp-block-column has-eb-garamond-font-family has-medium-font-size" style="flex-basis:33.33%"><!-- wp:group {"style":{"border":{"radius":"2px","width":"1px"},"spacing":{"padding":{"left":"var:preset|spacing|30","top":"var:preset|spacing|20","bottom":"var:preset|spacing|20"}}},"borderColor":"light-grey-1","layout":{"type":"constrained"}} -->
<div class="wp-block-group has-border-color has-light-grey-1-border-color" style="border-width:1px;border-radius:2px;padding-top:var(--wp--preset--spacing--20);padding-bottom:var(--wp--preset--spacing--20);padding-left:var(--wp--preset--spacing--30)"><!-- wp:paragraph {"style":{"layout":{"selfStretch":"fit","flexSize":null},"elements":{"link":{"color":{"text":"var:preset|color|charcoal-0"}}}},"textColor":"charcoal-0","fontSize":"heading-6"} -->
<p class="has-charcoal-0-color has-text-color has-link-color has-heading-6-font-size">540,537 members</p>
<p class="has-charcoal-0-color has-text-color has-link-color has-heading-6-font-size">540,537 attendees</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it'd be accurate to change this. That number is the # of meetup.com group members (plus WordCamp attendees, but that doesn't affect it significantly), and the number of attendees is likely to be significantly different.

If we really want to say attendees, we could try to estimate the # based on RSVPs, but I don't think it'd be accurate enough to publish. IMO members is the most accurate/meaningful stat we can use here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that context. I was going off the designs. I'll provide that feedback and switch it back to members today.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO members is the most accurate/meaningful stat we can use here.

I definitely see what you mean. I'm just unsure if "members", despite being accurate, is the right term to use. It does have hints of exclusivity and seems directly tied to Meetup.com's terminology, not necessarily WordPress's. When "members" are talked about in WP ways, I've typically seen it explicitly contextualized as "community members"... which is too long (as usual 😅).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So summing up the problem, if we use "attendees", we will be underrepresenting the actual number of attendees.

I also find members to be an inclusive term. What about just people?

Simple is as simple does.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

people is accurate and simple, for sure. Also feels too generic/passive. (and what of all the pet contributors? 😎)

I'd suggest one of the following (for now), with my preference being 1:

  1. participants: technically accurate, the bar for participation can be fluid, i.e., as low as just becoming a member on Meetup.com or as high as attending and contributing at a WordCamp.
  2. contributors: perhaps not entirely inclusive/accurate, but directly related to the project and also used elsewhere on the page already.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 that's a good point, we definitely don't want it to feel exclusionary. I like participants, thanks for thinking of that!

I think the problem with attendees is more that it _over_represents the number of attendees, since so many people join a meetup group, and even RSVP to an event, but don't actually show up. IMO accuracy is the most important factor, and it'd be better to err on the side of too low than too high. My concern is that inflating stats, even unintentionally, would erode trust.

I'll go ahead and update it to participants since we're coming up on the deadline to launch, but I'm happy to continue discussing it if y'all would like to iterate on that, or make any changes.

<!-- /wp:paragraph --></div>
<!-- /wp:group --></div>
<!-- /wp:column --></div>
Expand Down