Verify the order before checking for error flags #1295
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at the checkout process as part of #1296 I noticed that
verify_order()
is run after the check for error_flags, which means ifverify_order()
flags any issues with the order, the checkout still proceeds.Some of the checks within the
verify_order()
method is duplicated within the checkout process already, but this ensures that any issues encountered during validation do properly stop the checkout process.This might reduce the number of
ticket_excess
issues that some WordCamps can run into during high ticket loads.