Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structured Event Data: Include the Event details on past years #1329

Open
wants to merge 3 commits into
base: production
Choose a base branch
from
Open

Structured Event Data: Include the Event details on past years #1329

wants to merge 3 commits into from

Commits on May 30, 2024

  1. Structured Event Data: Include the Event details on past years 

    The code erroneously suggests that Scheduled should only be for future events, whereas the Scheduled state specifies:

> The event is taking place or has taken place on the startDate as scheduled

Therefor, Scheduled in the past is valid and should not be interpreted by clients as a future event.

This may help with search engines determining the year of the content they're linking to.
    @dd32
    dd32 authored May 30, 2024
    Configuration menu
    Copy the full SHA
    e011b1a View commit details
    Browse the repository at this point in the history

  2. Structured Data: Only set it as scheduled for actual Scheduled events 

    The previous commit was too greedy, applying to events that were pre-schedule as well as closed.

This reverts it to instead add the closed state.
    @dd32
    dd32 authored May 30, 2024
    Configuration menu
    Copy the full SHA
    f845ef0 View commit details
    Browse the repository at this point in the history

  3. .

    @dd32
    dd32 authored May 30, 2024
    Configuration menu
    Copy the full SHA
    43f11d5 View commit details
    Browse the repository at this point in the history