Revert [59177].

This was the wrong version of the patch.

Unprops @joedolson.

git-svn-id: https://develop.svn.wordpress.org/trunk@59178 602fd350-edb4-49c9-b593-d223f7449a82

src/wp-includes/class-walker-nav-menu.php

@@ -126,7 +126,6 @@ public function end_lvl( &$output, $depth = 0, $args = null ) {
 	 * @since 4.4.0 The {@see 'nav_menu_item_args'} filter was added.
 	 * @since 5.9.0 Renamed `$item` to `$data_object` and `$id` to `$current_object_id`
 	 *              to match parent class for PHP 8 named parameter support.
-	 * @since 6.7.0 Removed redundant title attributes.
 	 *
 	 * @see Walker::start_el()
 	 *
@@ -213,22 +212,8 @@ public function start_el( &$output, $data_object, $depth = 0, $args = null, $cur
 
 		$output .= $indent . '<li' . $li_attributes . '>';
 
-		/** This filter is documented in wp-includes/post-template.php */
-		$title = apply_filters( 'the_title', $menu_item->title, $menu_item->ID );
-
-		/**
-		 * Filters a menu item's title.
-		 *
-		 * @since 4.4.0
-		 *
-		 * @param string   $title     The menu item's title.
-		 * @param WP_Post  $menu_item The current menu item object.
-		 * @param stdClass $args      An object of wp_nav_menu() arguments.
-		 * @param int      $depth     Depth of menu item. Used for padding.
-		 */
-		$title = apply_filters( 'nav_menu_item_title', $title, $menu_item, $args, $depth );
-
 		$atts           = array();
+		$atts['title']  = ! empty( $menu_item->attr_title ) ? $menu_item->attr_title : '';
 		$atts['target'] = ! empty( $menu_item->target ) ? $menu_item->target : '';
 		$atts['rel']    = ! empty( $menu_item->xfn ) ? $menu_item->xfn : '';
 
@@ -244,14 +229,6 @@ public function start_el( &$output, $data_object, $depth = 0, $args = null, $cur
 
 		$atts['aria-current'] = $menu_item->current ? 'page' : '';
 
-		if ( ! empty( $menu_item->attr_title )
-			&& trim( strtolower( $menu_item->attr_title ) ) !== trim( strtolower( $title ) )
-		) {
-			$atts['title'] = $menu_item->attr_title;
-		} else {
-			$atts['title'] = '';
-		}
-
 		/**
 		 * Filters the HTML attributes applied to a menu item's anchor element.
 		 *
@@ -274,6 +251,21 @@ public function start_el( &$output, $data_object, $depth = 0, $args = null, $cur
 		$atts       = apply_filters( 'nav_menu_link_attributes', $atts, $menu_item, $args, $depth );
 		$attributes = $this->build_atts( $atts );
 
+		/** This filter is documented in wp-includes/post-template.php */
+		$title = apply_filters( 'the_title', $menu_item->title, $menu_item->ID );
+
+		/**
+		 * Filters a menu item's title.
+		 *
+		 * @since 4.4.0
+		 *
+		 * @param string   $title     The menu item's title.
+		 * @param WP_Post  $menu_item The current menu item object.
+		 * @param stdClass $args      An object of wp_nav_menu() arguments.
+		 * @param int      $depth     Depth of menu item. Used for padding.
+		 */
+		$title = apply_filters( 'nav_menu_item_title', $title, $menu_item, $args, $depth );
+
 		$item_output  = $args->before;
 		$item_output .= '<a' . $attributes . '>';
 		$item_output .= $args->link_before . $title . $args->link_after;