Skip to content

Commit

Permalink
Bundled Themes: Revert 56451.
Browse files Browse the repository at this point in the history
Reverts [56451] to avoid the following issues:

* missing the default `font-size` for anyone who does not use the size control.
* unintentional reduction in citation's `line-height` down to the `--pullquote--line-height` value (1.3 instead of 1.6).

With 6.4 RC1 happening shortly, this revert is necessary to avoid shipping this issues in the release, while giving the time needed to resolve in the next cycle.

Follow-up to [56451].

Props sabernhardt, nicolefurlan.
See #57854.

git-svn-id: https://develop.svn.wordpress.org/trunk@56959 602fd350-edb4-49c9-b593-d223f7449a82
  • Loading branch information
hellofromtonya committed Oct 17, 2023
1 parent 8077c07 commit 7856fcb
Show file tree
Hide file tree
Showing 11 changed files with 58 additions and 81 deletions.
23 changes: 12 additions & 11 deletions src/wp-content/themes/twentytwentyone/assets/css/ie-editor.css
Original file line number Diff line number Diff line change
Expand Up @@ -1507,11 +1507,6 @@ pre.wp-block-preformatted {
color: currentColor;
border-color: currentColor;
position: relative;
font-weight: 700;
font-style: normal;
font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, Oxygen-Sans, Ubuntu, Cantarell, "Helvetica Neue", sans-serif;
letter-spacing: normal;
line-height: 1.3;
}

.wp-block-pullquote blockquote::before {
Expand All @@ -1526,14 +1521,20 @@ pre.wp-block-preformatted {
}

.wp-block-pullquote p {
font-family: inherit;
font-size: inherit;
font-style: inherit;
font-weight: inherit;
letter-spacing: inherit;
line-height: inherit;
font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, Oxygen-Sans, Ubuntu, Cantarell, "Helvetica Neue", sans-serif;
font-size: 2rem;
font-style: normal;
font-weight: 700;
letter-spacing: normal;
line-height: 1.3;
margin: 0;
}
@media only screen and (min-width: 652px) {

.wp-block-pullquote p {
font-size: 2rem;
}
}

.wp-block-pullquote a {
color: currentColor;
Expand Down

Large diffs are not rendered by default.

23 changes: 12 additions & 11 deletions src/wp-content/themes/twentytwentyone/assets/css/ie.css
Original file line number Diff line number Diff line change
Expand Up @@ -3655,11 +3655,6 @@ pre.wp-block-preformatted {
color: currentColor;
border-color: currentColor;
position: relative;
font-weight: 700;
font-style: normal;
font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, Oxygen-Sans, Ubuntu, Cantarell, "Helvetica Neue", sans-serif;
letter-spacing: normal;
line-height: 1.3;

/**
* Block Options
Expand All @@ -3678,14 +3673,20 @@ pre.wp-block-preformatted {
}

.wp-block-pullquote p {
font-family: inherit;
font-size: inherit;
font-style: inherit;
font-weight: inherit;
letter-spacing: inherit;
line-height: inherit;
font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, Oxygen-Sans, Ubuntu, Cantarell, "Helvetica Neue", sans-serif;
font-size: 2rem;
font-style: normal;
font-weight: 700;
letter-spacing: normal;
line-height: 1.3;
margin: 0;
}
@media only screen and (min-width: 652px) {

.wp-block-pullquote p {
font-size: 2rem;
}
}

.wp-block-pullquote a {
color: currentColor;
Expand Down

Large diffs are not rendered by default.

17 changes: 6 additions & 11 deletions src/wp-content/themes/twentytwentyone/assets/css/style-editor.css
Original file line number Diff line number Diff line change
Expand Up @@ -1419,11 +1419,6 @@ pre.wp-block-preformatted {
color: currentColor;
border-color: currentColor;
position: relative;
font-weight: 700;
font-style: var(--pullquote--font-style);
font-family: var(--pullquote--font-family);
letter-spacing: var(--pullquote--letter-spacing);
line-height: var(--pullquote--line-height);
}

.wp-block-pullquote blockquote::before {
Expand All @@ -1438,12 +1433,12 @@ pre.wp-block-preformatted {
}

.wp-block-pullquote p {
font-family: inherit;
font-size: inherit;
font-style: inherit;
font-weight: inherit;
letter-spacing: inherit;
line-height: inherit;
font-family: var(--pullquote--font-family);
font-size: var(--pullquote--font-size);
font-style: var(--pullquote--font-style);
font-weight: 700;
letter-spacing: var(--pullquote--letter-spacing);
line-height: var(--pullquote--line-height);
margin: 0;
}

Expand Down

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,6 @@
color: currentColor;
border-color: currentColor;
position: relative;
font-weight: 700;
font-style: var(--pullquote--font-style);
font-family: var(--pullquote--font-family);
letter-spacing: var(--pullquote--letter-spacing);
line-height: var(--pullquote--line-height);

blockquote::before {
color: currentColor;
Expand All @@ -25,12 +20,12 @@
}

p {
font-family: inherit;
font-size: inherit;
font-style: inherit;
font-weight: inherit;
letter-spacing: inherit;
line-height: inherit;
font-family: var(--pullquote--font-family);
font-size: var(--pullquote--font-size);
font-style: var(--pullquote--font-style);
font-weight: 700;
letter-spacing: var(--pullquote--letter-spacing);
line-height: var(--pullquote--line-height);
margin: 0;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,6 @@
color: currentColor;
border-color: currentColor;
position: relative;
font-weight: 700;
font-style: var(--pullquote--font-style);
font-family: var(--pullquote--font-family);
letter-spacing: var(--pullquote--letter-spacing);
line-height: var(--pullquote--line-height);

blockquote::before {
color: currentColor;
Expand All @@ -25,12 +20,12 @@
}

p {
font-family: inherit;
font-size: inherit;
font-style: inherit;
font-weight: inherit;
letter-spacing: inherit;
line-height: inherit;
font-family: var(--pullquote--font-family);
font-size: var(--pullquote--font-size);
font-style: var(--pullquote--font-style);
font-weight: 700;
letter-spacing: var(--pullquote--letter-spacing);
line-height: var(--pullquote--line-height);
margin: 0;
}

Expand Down
17 changes: 6 additions & 11 deletions src/wp-content/themes/twentytwentyone/style-rtl.css
Original file line number Diff line number Diff line change
Expand Up @@ -2814,11 +2814,6 @@ pre.wp-block-preformatted {
color: currentColor;
border-color: currentColor;
position: relative;
font-weight: 700;
font-style: var(--pullquote--font-style);
font-family: var(--pullquote--font-family);
letter-spacing: var(--pullquote--letter-spacing);
line-height: var(--pullquote--line-height);

/**
* Block Options
Expand All @@ -2837,12 +2832,12 @@ pre.wp-block-preformatted {
}

.wp-block-pullquote p {
font-family: inherit;
font-size: inherit;
font-style: inherit;
font-weight: inherit;
letter-spacing: inherit;
line-height: inherit;
font-family: var(--pullquote--font-family);
font-size: var(--pullquote--font-size);
font-style: var(--pullquote--font-style);
font-weight: 700;
letter-spacing: var(--pullquote--letter-spacing);
line-height: var(--pullquote--line-height);
margin: 0;
}

Expand Down
17 changes: 6 additions & 11 deletions src/wp-content/themes/twentytwentyone/style.css
Original file line number Diff line number Diff line change
Expand Up @@ -2824,11 +2824,6 @@ pre.wp-block-preformatted {
color: currentColor;
border-color: currentColor;
position: relative;
font-weight: 700;
font-style: var(--pullquote--font-style);
font-family: var(--pullquote--font-family);
letter-spacing: var(--pullquote--letter-spacing);
line-height: var(--pullquote--line-height);

/**
* Block Options
Expand All @@ -2847,12 +2842,12 @@ pre.wp-block-preformatted {
}

.wp-block-pullquote p {
font-family: inherit;
font-size: inherit;
font-style: inherit;
font-weight: inherit;
letter-spacing: inherit;
line-height: inherit;
font-family: var(--pullquote--font-family);
font-size: var(--pullquote--font-size);
font-style: var(--pullquote--font-style);
font-weight: 700;
letter-spacing: var(--pullquote--letter-spacing);
line-height: var(--pullquote--line-height);
margin: 0;
}

Expand Down
2 changes: 1 addition & 1 deletion src/wp-content/themes/twentytwentyone/style.css.map

Large diffs are not rendered by default.

0 comments on commit 7856fcb

Please sign in to comment.