Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR 1751 + add tests, improve coverage. #3044

Closed
wants to merge 11 commits into from
+1,662 −1
Closed

Update PR 1751 + add tests, improve coverage. #3044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4cec259
Add unit tests for some methods in the WP Upgrader class
moorscode Oct 8, 2021
d803089
Remove new constant in Tests bootstrap.
Jul 30, 2022
f641368
Update PR 2463 to add tests, improve coverage, align with current Cor…
Jul 30, 2022
aa660cd
Source: Add type checking to `WP_Upgrader::install_package()`.
Sep 10, 2022
17c8ae5
Source: Add missing `no_package` string.
Sep 10, 2022
275a8ab
Docs fixes + isolate tests that set constants.
Mar 1, 2023
c19d7d8
Make compliant with WPCS 3.0.
Oct 17, 2023
77e8e3a
Use `$wpdb` instead in lock test.
Oct 17, 2023
d0a67cd
Increase the number of strings tested.
Oct 17, 2023
0a540ab
Add value for `no_package` generic string.
Oct 17, 2023
a85b68f
Merge branch 'trunk' into add-wp-upgrader-unit-tests-update
peterwilsoncc Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/wp-admin/includes/class-wp-upgrader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,8 @@ public function generic_strings() {
/* translators: %s: Directory name. */
$this->strings['fs_no_folder'] = __( 'Unable to locate needed folder (%s).' );

$this->strings['no_package'] = __( 'Package not available.' );

$this->strings['download_failed'] = __( 'Download failed.' );
$this->strings['installing_package'] = __( 'Installing the latest version…' );
$this->strings['no_files'] = __( 'The package contains no files.' );
Expand Down Expand Up @@ -527,7 +529,10 @@ public function install_package( $args = array() ) {
set_time_limit( 300 );
}

if ( empty( $source ) || empty( $destination ) ) {
if (
( ! is_string( $source ) || '' === trim( $source ) ) ||
( ! is_string( $destination ) || '' === trim( $destination ) )
) {
return new WP_Error( 'bad_request', $this->strings['bad_request'] );
}
$this->skin->feedback( 'installing_package' );
Expand Down
Loading