Add a check for zero-byte files. #5374
Conversation
| show-progress: ${{ runner.debug == '1' && 'true' || 'false' }} | ||
|
|
||
| - name: Find zero-byte files | ||
| run: find src/wp-content/themes/${{ matrix.theme }} -size 0 |
There was a problem hiding this comment.
Something like this may work:
if [[ "" != $(find src/wp-content/themes/${{ matrix.theme }} -size 0) ]]; then exit 1; fiNot sure if that translates to the workflow properly, but you get the gist 🙂
There was a problem hiding this comment.
Ah! I didn't see this before making 7f5fb21. What do you think about that approach? I think it reads a lot easier. But not opposed to something like above either.
There was a problem hiding this comment.
The other approach works but I'm not sure that it'll be clear that the diff check is part of, and required for, the empty file checks.
This also works in bash and may work here:
- name: Make sure there are no empty files.
- run: [[ ! $(find src/wp-content/themes/${{ matrix.theme }} -empty) ]]Do you think that's readable enough or not quite?
There was a problem hiding this comment.
Hmm, I've added this, but it doesn't seem to be flagging the empty images (I haven't synced my PR branch since that was fixed in trunk).
There was a problem hiding this comment.
Hmm, it should be producing a 1 exit code. Strange. Unless a readable oneliner comes to mind, the diff check makes most sense
There was a problem hiding this comment.
Strange! I just tried it again and it did work. 🤷♂️
`find` always returns a successful status code, unless there is a problem traversing directories. Instead, let's delete empty files and then check that there are no changes in GIT.
…into add/0-byte-file-check
Trac ticket: https://core.trac.wordpress.org/ticket/59527
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.