-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport/55415 make duotone support compatible with enhanced pagination #5540
Conversation
I'm not finding an easy way to test that in I tried checking that Any help would be kindly appreciated. EDIT: Tests done 😄 |
152b4ea
to
d264e88
Compare
Hi there! Pinging @tellthemachines for a review 😅 |
== Patch Report Patch tested: https://patch-diff.githubusercontent.com/raw/WordPress/wordpress-develop/pull/5540.diff How to read this report: ==== Environment
==== Steps to Reproduce
==== Steps to Test Patch
==== Test Results
==== Screenshots After patch: |
For commit prep, I'll be pushing a few commits to this PR to address the failing PHP 8.3 test, review notes from @aaronjorbin, resetting the reflected property's visibility in the test, and a few other minor formatting things. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Ready commit
Committed via https://core.trac.wordpress.org/changeset/56991. |
Co-authored with @luisherranz
Trac ticket: https://core.trac.wordpress.org/ticket/59694
This PR backports #55415 that fixes an issue with duotone and enhanced pagination. All the context is inside Gutenberg PR.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.