Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#59715: Fix blocks RTL style loading issue #5589

Conversation

mukeshpanchal27
Copy link
Member

Trac ticket: https://core.trac.wordpress.org/ticket/59715

The RTL style issue emerged following the r56524 commit in 6.3.2. Following this commit, the full path for the RTL style is now being used, as exemplified by /var/www/src/wp-includes/blocks/navigation/style-rtl.css.

Within the $files variable, we maintain a list of styles that must be loaded alongside the block path, for instance, blockname/blockstyle.css.

However, an issue arises with the condition:

if ( is_rtl() && in_array( $rtl_file, $files, true ) ) {

This condition is failing, leading to the failure to load the RTL style. Instead, the normal style for the block is loaded.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review October 30, 2023 06:28
@SergeyBiryukov
Copy link
Member

Thanks for the PR! Merged in r57028.

@aijaz227

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants