Improve inline documentation and avoid escaping values passed to $processor->set_attribute()

[michalczaplinski]

This PR improves the inline documentation for the Block Bindings API.

It also implements a minor improvement from #5888 (comment). The values passed to $processor->set_attribute() should not be escaped.

Trac ticket: https://core.trac.wordpress.org/ticket/60282

---

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

Core Committers: Use this line as a base for the props when committing in SVN:

Props czapla, gziolo, retrofox.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: michalczaplinski <[email protected]>
Co-authored-by: gziolo <[email protected]>
Co-authored-by: retrofox <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

• The Plugin and Theme Directories cannot be accessed within Playground.
• All changes will be lost when closing a tab with a Playground instance.
• All changes will be lost when refreshing the page.
• A fresh instance is created each time the link below is clicked.
• Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
  it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

[retrofox]

LGTM

[gziolo]

Thank you for iterating on the PHPDoc for register_block_bindings_source. I'm wondering how much WP_Block_Bindings_Registry::register should stay in sync. Maybe it's enough to put there @see register_block_bindings_source annotation. I left two suggestions to discuss further before I commit changes.

[michalczaplinski]

Maybe it's enough to put there @see register_block_bindings_source annotation. I left two suggestions to discuss further before I commit changes.

That makes sense. I also added a note in 94385a5 saying it's a low-level method and register_block_bindings_source() should be used in most cases instead.

[gziolo]

Committed with https://core.trac.wordpress.org/changeset/57560 and https://core.trac.wordpress.org/changeset/57561.