-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(wpadmin): Fix URL sanitization for handling Unicode #7512
base: trunk
Are you sure you want to change the base?
Conversation
Replaced sanitize_text_field() with esc_url_raw() for sanitizing URLs passed via $_REQUEST['url'].
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Yes, it's working properly. |
@@ -84,7 +84,7 @@ | |||
} | |||
} | |||
|
|||
$url = ! empty( $_REQUEST['url'] ) ? sanitize_text_field( wp_unslash( $_REQUEST['url'] ) ) : ''; | |||
$url = ! empty( $_REQUEST['url'] ) ? esc_url_raw( wp_unslash( $_REQUEST['url'] ) ) : ''; | |||
$return = ! empty( $_REQUEST['return'] ) ? sanitize_text_field( wp_unslash( $_REQUEST['return'] ) ) : ''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also need to use esc_url_raw
here, since it's also a URL?
Replaced sanitize_text_field() with esc_url_raw() for sanitizing URLs passed via
$_REQUEST['url']
. This change fixes an issue where the URLexample.com/หน้าภาษาไทย
would incorrectly returnexample.com//
due to improper sanitization when clicking on the Customize button through the admin bar.This ensures that URLs containing non-Latin characters are correctly preserved and prevents unexpected behavior in the customizer.
Happy to hear feedback on this approach or if there's a better way to handle this scenario! Let me know if this change introduces any concerns.
Trac ticket: https://core.trac.wordpress.org/ticket/61317