Skip to content

Commit

Permalink
Set emptyOutDir to false in php-wasm/web/project.json (#814)
Browse files Browse the repository at this point in the history
In CI, Vite occasionally fails with the following error: 

> ENOTEMPTY: directory not empty, rmdir dist/packages/php-wasm/web/light

That directory is implicitly created by preserve-php-loaders-imports
plugin. Vite attempts to synchronously empty it, and yet some files are
somehow left in there. Perhaps it’s a bug in Vite? Or something writes
those files in parallel?

For now, let's just abstain from emptying that directory. In the future,
if more problems emerge, we may need to get to the bottom of that.
  • Loading branch information
adamziel authored Nov 27, 2023
1 parent 0bdb332 commit 00305f4
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions packages/php-wasm/web/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
"executor": "@nx/vite:build",
"outputs": ["{options.outputPath}"],
"options": {
"emptyOutDir": false,
"outputPath": "dist/packages/php-wasm/web"
}
},
Expand Down

0 comments on commit 00305f4

Please sign in to comment.