Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blueprints] setSiteLanguage step – download the latest RC translations for Nightly and Beta builds of WordPress #1987

Merged
merged 14 commits into from
Nov 19, 2024
Merged

[Blueprints] setSiteLanguage step – download the latest RC translations for Nightly and Beta builds of WordPress #1987

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
367e32b
[Blueprints] Download the latest RC translations for Nightly and Beta…
bgrgicak Nov 7, 2024
b28ea9d
Document released version translation fetching
bgrgicak Nov 7, 2024
0b975df
Document released version translations
bgrgicak Nov 7, 2024
317671b
Add language translation E2E tests
bgrgicak Nov 7, 2024
c9590cf
Merge branch 'trunk' into fix/rc-and-nigtly-translation-fetching
bgrgicak Nov 7, 2024
fc73235
Switch WP version in tests
bgrgicak Nov 7, 2024
848fe8c
Update test names
bgrgicak Nov 7, 2024
8660c14
Update docstrings
bgrgicak Nov 14, 2024
df4d543
Merge branch 'trunk' into fix/rc-and-nigtly-translation-fetching
adamziel Nov 15, 2024
0d062ea
Remove mention of supported versions
bgrgicak Nov 18, 2024
8cf6394
Default to latest version for translations
bgrgicak Nov 18, 2024
a339b9a
Merge branch 'trunk' into fix/rc-and-nigtly-translation-fetching
bgrgicak Nov 18, 2024
57658e6
Update docblock
bgrgicak Nov 18, 2024
f1f5842
Replace versionStringToLoadedWordPressVersion with a regex and add tests
bgrgicak Nov 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/playground/blueprints/src/lib/steps/set-site-language.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@ const getWordPressTranslationUrl = (wpVersion: string, language: string) => {
* RC and beta versions don't have individual translation packages.
* They all share the same "RC" translation package.
*
* Development versions (called nightly in Playground) don't have
* a "development" translation package.
* Nightly versions don't have a "nightly" translation package.
* So, the best we can do is download the RC translation package,
* because it contains the latest available translations.
*
Expand Down
10 changes: 8 additions & 2 deletions packages/playground/wordpress/src/version-detect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,19 @@ export async function getLoadedWordPressVersion(
}

/**
* Returns a WordPress build version string known to Playground
* Returns a WordPress build version string supported by Playground,
* for a given WordPress version string.
*
* Playground supports the last 4 major.minor versions of WordPress,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect, though. There's nothing in this function that limits the returned version to the last 4 major releases.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, I wanted to explain what supported means with that sentence, but it's actually not relevant.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the mention of support in 0d062ea because it's not relevant.

* the latest beta or RC release (depending on which is newer),
* and nightly releases.
* You can find the full list of supported build versions in
* packages/playground/wordpress-builds/src/wordpress/wp-versions.json
*
* Each released version will be converted to the major.minor format.
* For example 6.6.1 will be converted to 6.6.
*
* Release candidates (RC) and beta releases are converted to the "beta"
* Release candidates (RC) and beta releases are converted to "beta".
*
* Nightly releases are converted to "nightly".
*
Expand Down