E2E: Disable a flaky deployment test #2016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disables an E2E test that notoriously fails: > When a new website version is deployed while the old version is still loaded, creating a new site should still work. I would love to improve this test, but this particular one is tedious and the process could take a few days I am not willing to put in right now. At the same time, keeping a failing test around lowers our confidence in the E2E test overall. Skipping it and keeping the code around for the next time we adjust the service worker seems like a good compromise, especially since the deployments seem to be in a good place now without many reports of the stale Playground version sticking around for too long.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables an E2E test that notoriously fails:
I would love to improve this test, but this particular one is tedious and the process could take a few days I am not willing to put in right now. At the same time, keeping a failing test around lowers our confidence in the E2E test overall. Skipping it and keeping the code around for the next time we adjust the service worker seems like a good compromise, especially since the deployments seem to be in a good place now without many reports of the stale Playground version sticking around for too long.