Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move sidebar code to new "sidebar container" block #63

Merged
merged 1 commit into from
May 8, 2023

Conversation

ryelle
Copy link
Collaborator

@ryelle ryelle commented May 5, 2023

Companion PR to a change in wporg-mu-plugins: WordPress/wporg-mu-plugins#397

Alternative to #58, because this also removes the aside wrapper from the sidebar.

Screenshots

There should be no visual change.

How to test the changes in this Pull Request:

  1. View an article
  2. The table of contents should appear in the sidebar (if the screen is wider than 1200px, or inline if less).
  3. If the ToC is in the sidebar position, and it's short enough, it should be sticky to the screen as you scroll.
  4. Overall, there should be no behavior or visual change from production.

@ryelle ryelle added the [Component] Theme Templates, patterns, CSS label May 5, 2023
@ryelle ryelle self-assigned this May 5, 2023
@ryelle ryelle merged commit 116eb14 into trunk May 8, 2023
@ryelle ryelle deleted the try/sidebar-container-block branch May 8, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Theme Templates, patterns, CSS
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant