-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lint JS and CSS #85
Lint JS and CSS #85
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I am just confused regarding the tooling, shall we add wp-scripts
for this, like in https://github.com/GlotPress/gp-translation-helpers/blob/main/composer.json ?
(I'm assuming you meant package.json instead of It didn't occur to me to use Currently we don't yet have any npm/node dependencies, so we could consider sticking with |
I rebased with trunk to fix conflicts. |
Oops, indeed.
I wasn't aware that phpcs can do this reformatting. I guess it's ok for the moment :-) |
Ok, cool. I think it's a good time to merge this one now because there's only #74 which will be affected. Merging. |
This is the final linting PR. It's mostly just fixing whitespace. In the js, I refactored a little to extract functions out of functions.
This will likely cause conflicts with #74. I can help resolve conflicts there, or it if gets merged, I will resolve conflicts here.
Diff ignoring whitespace changes