Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add export content parsers tests #181

Closed
wants to merge 10 commits into from

Conversation

adamwoodnz
Copy link
Contributor

Fixes #179

Props @iandunn

How to test the changes in this Pull Request:

@adamwoodnz adamwoodnz added the [Component] Tools Build tools, packages, etc label Jan 29, 2023
@adamwoodnz adamwoodnz self-assigned this Jan 29, 2023
@@ -23,6 +23,7 @@ phpcs.xml.dist
/source/wp-content/mu-plugins/*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe need to add /source/wp-content/tests/* here then un-ignore phpunit to make docker load tests...

@ryelle ryelle mentioned this pull request Jan 31, 2023
@adamwoodnz adamwoodnz force-pushed the fix/177-export-content-parse-list-items branch from 22e6f72 to 406e4c2 Compare January 31, 2023 23:15
Base automatically changed from fix/177-export-content-parse-list-items to trunk February 1, 2023 02:39
@ryelle
Copy link
Contributor

ryelle commented Feb 1, 2023

@adamwoodnz I just pushed a few changes that get the tests to work in docker — I've set this up a few times :) I used WordPress/wporg-mu-plugins#299 as the most recent reference. Make sure to run the following to to get the polyfill package, and update the containers with the new .wp-env.json config.

yarn wp-env stop
composer install # or composer update
yarn wp-env start

@adamwoodnz adamwoodnz linked an issue Feb 1, 2023 that may be closed by this pull request
@adamwoodnz
Copy link
Contributor Author

@adamwoodnz I just pushed a few changes that get the tests to work in docker — I've set this up a few times :)

Thanks so much! That's awesome

ryelle added a commit that referenced this pull request Apr 3, 2023
ryelle added a commit that referenced this pull request Apr 3, 2023
ryelle added a commit that referenced this pull request Apr 4, 2023
…nifest (#247)

* Update parsers

This includes the updates from WordPress/wordpress.org#90, a new AttributeParser for attribute-only blocks, and a fix for the ListItem block to allow child lists.
Fixes #211

* Add phpunit test infrastructure and tests

Pulled from #181

* Remove swag page from manifest

* Update content with new parser

* Add a phpunit workflow
@ryelle ryelle closed this in #247 Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Tools Build tools, packages, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit tests for export-content parsers
2 participants