Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patterns: Update the WP20 banner, use Link Wrapper block #265

Merged
merged 2 commits into from
May 12, 2023

Conversation

ryelle
Copy link
Contributor

@ryelle ryelle commented May 11, 2023

This PR switches the large banner on the homepage to a smaller banner, wrapped in a link. This also updates the content of the banner to highlight the WP20 website, instead of the swag.

Fixes #258, See WordPress/wporg-mu-plugins#398 (required before this can be merged)

cc @DanSoschin

Screenshots

Size Screenshot
400px
600px
960px 960
1400px 1400
Focus state focus
Hover state hover

How to test the changes in this Pull Request:

  1. Make sure New Block: Link Wrapper to add a link to a group of blocks. wporg-mu-plugins#398 is applied or already merged
  2. Check out this PR, build the CSS
  3. View the homepage, it should have the smaller banner.

@ryelle ryelle added the [Component] Content Bugs or issues related to the page content label May 11, 2023
@ryelle ryelle requested review from adamwoodnz, StevenDufresne and a team May 11, 2023 20:50
@ryelle ryelle self-assigned this May 11, 2023
Copy link
Contributor

@adamwoodnz adamwoodnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me but doesn't quite match design:

  1. Height in design is 60px
  2. Confetti looks like it's lower opacity (can't see any full color orange or white discs)
  3. The 'View Events' link is missing (maybe intentional due to the whole banner being clickable?)

Screen Shot 2023-05-12 at 10 20 54 AM

Screen Shot 2023-05-12 at 10 25 54 AM

Screen Shot 2023-05-12 at 10 20 44 AM

@ryelle
Copy link
Contributor Author

ryelle commented May 11, 2023

Most of that was intentional, but I'll let @marko-srb chime in if I should change anything

Height in design is 60px

This size worked better on smaller screens, otherwise it felt like there wasn't enough space when the text wrapped to additional lines.

Confetti looks like it's lower opacity (can't see any full color orange or white discs)

I put the overlay up to 50% based on feedback from @annezazu, "the dots in the background image make it hard to read the text" — maybe a different background image designed for this size would be better?

The 'View Events' link is missing (maybe intentional due to the whole banner being clickable?)

Yeah, intentional because the whole line is a link now.

Copy link

@marko-srb marko-srb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryelle

All the updates are fine. One suggestion/question.

  • Can we reduce text size on mobile only? (in original design I went with 13 for mobile)

If not, can we reduce the space from logo to the text, to about half of what's done. See screenshot:
Screen Shot 2023-05-12 at 15 57 22

Other than that, we can push this change.

P.S. It is fine to narrow that space on both responsive and desktop.

Thanks!

@ryelle
Copy link
Contributor Author

ryelle commented May 12, 2023

I've tweaked the spacing & updated the font size on small (<500px) screens:

Large Small
large screen small screen

@ryelle ryelle force-pushed the update/home-banner branch from e09ab47 to 3dac924 Compare May 12, 2023 15:56
@ryelle ryelle merged commit 6e99668 into trunk May 12, 2023
@ryelle ryelle deleted the update/home-banner branch May 12, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Content Bugs or issues related to the page content
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Improve the swag banner
3 participants