Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content updates from Page Editor #438

Merged
merged 1 commit into from
May 13, 2024
Merged

Content updates from Page Editor #438

merged 1 commit into from
May 13, 2024

Conversation

github-actions[bot]
Copy link
Contributor

The content has changed in the Page Editor.
Please review, merge, and deploy.

@ryelle
Copy link
Contributor

ryelle commented Apr 30, 2024

@annezazu Was this change from your video walkthrough edits?

@annezazu
Copy link

Yes! The only thing that's changing here are renaming two group blocks in the page (so it matches with the rest of the page). No front end changes should be in place.

@github-actions github-actions bot force-pushed the automated/content-update branch from 7b4df63 to e4dde92 Compare May 3, 2024 16:21
@annezazu
Copy link

annezazu commented May 3, 2024

Jumping back in here to share a video of what the /blocks changes should look like:

blocks.iteration.mov

Let me know if there are any questions or concerns! It looks a bit different than what's in the editor so I wanted to make sure we're good to go.

@ryelle
Copy link
Contributor

ryelle commented May 3, 2024

Here's a screenshot of what it will look like from this branch:

blocks

Has this been reviewed by anyone else?

@annezazu
Copy link

annezazu commented May 3, 2024

That's right! @jasmussen can you look this over once more to be certain? I'd love another set of eyes.

@jasmussen
Copy link
Contributor

Looks good at a glance. Are you able to provide a quick screenshot of mobile? In the editor, the "edge spacing" variable? In the editor I think it behaves differently on the frontend. Just want to make sure it isn't 80px wide in the mobile space.

Also a quick glance from @marko-srb if he has time, would be useful. This mini-iteration, which is not meant to preclude a future update, is highly based on his work.

@ryelle
Copy link
Contributor

ryelle commented May 6, 2024

I'm pretty sure the direct preview links aren't working anymore (but there it is, just in case), so you can also preview it yourself by going in to the page editor and clicking preview from there.

That said, here's the mobile screenshot:

@jasmussen
Copy link
Contributor

That looks correct, thank you!

To give a bit more context to this work, it is based on material created for #318, and this particular iteration was shared in Design Share 55 this morning. It has taken a couple of days of work to put together, so it is intentionally a light update. I will defer to you and Anne on when to put this live!

@annezazu
Copy link

annezazu commented May 6, 2024

Ready to ship whenever <3

@marko-srb
Copy link

marko-srb commented May 8, 2024

Just wanted to let you know that I got time to review this (although a bit late) and that I am ok with almost all the updates. One tiny thing is:

The intersection between two titles isn't nice when its one color — that's because the titles are below eachother and they lose a sense of differentiation/new area, it seems like its part of one thing/block but off, because of spacing... The quickest fix would be to adjust bottom part background to the reminder of dark bg below.

How does that work?

CC: @ryelle , @annezazu , @jasmussen

Screen Shot 2024-05-08 at 17 22 37

@jasmussen
Copy link
Contributor

Yep, I can make that change 👍 👍

@github-actions github-actions bot force-pushed the automated/content-update branch from e4dde92 to 27d8fda Compare May 13, 2024 08:05
@jasmussen
Copy link
Contributor

Okay, made a change and updated the edited blocks page. It now looks like this:

Screenshot 2024-05-13 at 10 04 36

I'm aware that's not 100% to what you showed, Marko, but unfortunately it was remarkably tricky to make the layout where the illustration is cropped on the right alone. And so to work on the larger screen sizes, as well as mobile, I had to un-crop the right side. Hope this works for you!

@annezazu
Copy link

annezazu commented May 13, 2024

That looks great to me :) Can we ship?

@ryelle
Copy link
Contributor

ryelle commented May 13, 2024

That looks great to me :) Can we ship?

Yep! I'll get this deployed shortly.

@ryelle ryelle merged commit 7a495ce into trunk May 13, 2024
@ryelle ryelle deleted the automated/content-update branch May 13, 2024 19:07
@jasmussen
Copy link
Contributor

jasmussen commented May 14, 2024

Thank you, nice work. One thing I noticed, on the mobile breakpoint, the illustration disappears:

Screenshot 2024-05-14 at 09 05 23

With the zero bottom margin, it looks a bit tight. There appears to be some custom CSS that hides this:

@media (max-width: 781px) {
    #intro .wp-block-column:last-child {
        display: none;
    }
}

If we can remove that, it would look like this, which works pretty well:
Screenshot 2024-05-14 at 09 07 39

I'll go ahead and open a new issue just to be sure it's captured. Thanks again.

@ndiego
Copy link
Member

ndiego commented May 14, 2024

I noticed that the link on the "Create a block" button is linking to an old URL. We have a redirect in place, so everything works, but I have updated it to the correct link in the Editor: https://developer.wordpress.org/block-editor/getting-started/tutorial/. This is a low priority, but whenever #440 is resolved, can we sync this change as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants