Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content updates from Page Editor #526

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Content updates from Page Editor #526

merged 1 commit into from
Dec 13, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 13, 2024

The following pages have been updated in the Page Editor.

Guides [https://wordpress.org/data-liberation/guides/]
Data Liberation [https://wordpress.org/data-liberation/]

Screenshots: https://github.com/WordPress/wporg-main-2022/actions/runs/12320561757/artifacts/2318679720

Please review, merge, and deploy.

@jasmussen
Copy link
Contributor

Noting that I'm working on this, but it's not yet fully ready. Here are "before" screenshots:

main before

guides before

I'm updating mainly to adjust some headings, some spacings, and I'm tentatively changing the h1 on the "Guides" subpage to just say "Guides" instead of "Data Liberation".

I'll update this thread when this is ready.

@github-actions github-actions bot force-pushed the automated/content-update branch 2 times, most recently from 447d348 to 1b946de Compare December 13, 2024 08:16
@jasmussen
Copy link
Contributor

I think this should be ready now. Updates to data-liberation, and data-liberation/guides:

Screenshot 2024-12-13 at 09 19 52

Screenshot 2024-12-13 at 09 19 39

  • A few changes to spacings and margins
  • Removed the h1 from "Guides" that said "Data Liberation", and changed the h2 that said "Guides" to be the new h1
  • Added a separator, some grouping, a gray color in the intro section
  • Used a Columns block to ensure the text content was overall left aligned, so it lined up with the "Data liberation" header in the top gray area.

Let me know if I got anything wrong!

@github-actions github-actions bot force-pushed the automated/content-update branch 5 times, most recently from 9516030 to 0b51301 Compare December 13, 2024 17:38
@ryelle
Copy link
Contributor

ryelle commented Dec 13, 2024

changed the h2 that said "Guides" to be the new h1

The reason I didn't just do this is that the individual guide headings would need to change to h2s, which would put Tools at the same level and that seemed odd. Just changing this heading creates an invalid level jump. The outline view is a great way to check:

Screenshot 2024-12-13 at 12 38 44 PM

However, I realized it's not right to have these links as headings in the first place, since they're not "heading" any content on the page. I've switched them to paragraph blocks and tweaked the styles so it should look the same, and the headings are correct now.

Screenshot 2024-12-13 at 12 42 32 PM

I've also switched these to Group blocks with left alignment, since the Columns blocks were adding extra space on smaller screens. In case you had tried that, it wouldn't have worked without a CSS override, see #465.

@github-actions github-actions bot force-pushed the automated/content-update branch from 0b51301 to 1694e91 Compare December 13, 2024 17:56
@ryelle ryelle merged commit b116c29 into trunk Dec 13, 2024
@ryelle ryelle deleted the automated/content-update branch December 13, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants