-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/325 responsive breadcrumb #437
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
We'll need to update the documentation site
Example: https://wordpress.org/documentation/article/learn-about-wordpress-and-version-history/
Looks good at a glance. The only thing we might tweak is the line-height which can get a bit compact on mobile, but we can ship this as is and revisit if need be. |
@jasmussen what do you think about rolling out these breadcrumbs on Documentation before we undergo the full reskin? Design Current It might be a sort of hybrid with the breadcrumbs moving out of the blue bar and sitting below, or we could also change that blue bar to charcoal, as is currently in progress on Developer: |
This reverts commit acf8ebb.
We can make documentation look the same as the developer handbook pages since they are essentially the same thing. |
The Docs update is now underway, and actually removes the breadcrumbs WordPress/wporg-documentation-2022#67 |
I have to offer an apology there, the breadcrumbs are meant to be there and I corrected this in the mockups. |
Fixes #325
Alternative to #348, which rather than truncating the central breadcrumbs, simply lets them stack, see comment.
It also updates the styles to match the Developer designs.
Screenshots