Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/325 responsive breadcrumb #437

Merged
merged 2 commits into from
Sep 4, 2023
Merged

Conversation

adamwoodnz
Copy link
Contributor

@adamwoodnz adamwoodnz commented Sep 1, 2023

Fixes #325

Alternative to #348, which rather than truncating the central breadcrumbs, simply lets them stack, see comment.

It also updates the styles to match the Developer designs.

Screenshots

Desktop Tablet Mobile
localhost_8888_coding-standards_inline-documentation-standards_php_(Desktop) localhost_8888_coding-standards_inline-documentation-standards_php_(iPad) localhost_8888_coding-standards_inline-documentation-standards_php_(Samsung Galaxy S20 Ultra) (1)

@adamwoodnz adamwoodnz self-assigned this Sep 1, 2023
@adamwoodnz adamwoodnz requested review from ryelle, StevenDufresne and a team September 1, 2023 03:12
@adamwoodnz adamwoodnz added the Redesign Related to the wordpress.org redesign project label Sep 1, 2023
@adamwoodnz adamwoodnz added this to the MVP milestone Sep 1, 2023
Copy link
Contributor

@StevenDufresne StevenDufresne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

We'll need to update the documentation site

Example: https://wordpress.org/documentation/article/learn-about-wordpress-and-version-history/

@jasmussen
Copy link
Collaborator

Looks good at a glance. The only thing we might tweak is the line-height which can get a bit compact on mobile, but we can ship this as is and revisit if need be.

@adamwoodnz adamwoodnz merged commit acf8ebb into trunk Sep 4, 2023
@adamwoodnz adamwoodnz deleted the fix/325-responsive-breadcrumb branch September 4, 2023 00:07
@adamwoodnz
Copy link
Contributor Author

adamwoodnz commented Sep 4, 2023

We'll need to update the documentation site

@jasmussen what do you think about rolling out these breadcrumbs on Documentation before we undergo the full reskin?

Design

Screenshot 2023-09-04 at 12 29 38 PM

Current

Screenshot 2023-09-04 at 12 32 20 PM

It might be a sort of hybrid with the breadcrumbs moving out of the blue bar and sitting below, or we could also change that blue bar to charcoal, as is currently in progress on Developer:

Screenshot 2023-09-04 at 12 36 16 PM

adamwoodnz added a commit that referenced this pull request Sep 4, 2023
adamwoodnz added a commit that referenced this pull request Sep 4, 2023
adamwoodnz added a commit that referenced this pull request Sep 4, 2023
@adamwoodnz adamwoodnz mentioned this pull request Sep 4, 2023
@StevenDufresne
Copy link
Contributor

We can make documentation look the same as the developer handbook pages since they are essentially the same thing.
Move the breadcrumb down into the content, add the title to the subnav and change the color. I would just ping #docs with that change to make sure everyone is aware.

@adamwoodnz
Copy link
Contributor Author

I only ask because Documentation is supposed to be going through a much wider reskin, and want to check that this new navigation style is compatible.

Screenshot 2023-09-04 at 5 57 31 PM

@adamwoodnz
Copy link
Contributor Author

The Docs update is now underway, and actually removes the breadcrumbs WordPress/wporg-documentation-2022#67

adamwoodnz added a commit that referenced this pull request Sep 7, 2023
adamwoodnz added a commit that referenced this pull request Sep 8, 2023
@jasmussen
Copy link
Collaborator

I have to offer an apology there, the breadcrumbs are meant to be there and I corrected this in the mockups.

adamwoodnz added a commit that referenced this pull request Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Site Breadcrumbs Redesign Related to the wordpress.org redesign project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Site Breadcrumbs should collapse on mobile
3 participants