Page Template: Add edge spacing padding to pages #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added a commit
that referenced
this pull request
Jan 31, 2022
* initial layout for podcast single post * remove unneeded rule * left column styles * positioning on mobile * fix rebase error * fixes for blob and overall padding * started header styles * template for archive page too * linting * Homepage: Fix horizontal scrolling (#236) * Reduce width of heading background * Refactor See All People styles * Alignments: Add negative margins to .alignfull (#235) * Add negative margins to alignfull * Change max-width from auto to none * Adjust caption padding for alignfull images * Add edge padding to pages (#237) * Blocks: Don't allow bold in quotes Fixes #140, see ae4ef79 * Use the core class for WP_Theme_JSON_Resolver The *_Gutenberg version is a back-compat class, and comes from Gutenberg itself, so the fonts don't load if Gutenberg is deactivated. Instead, we can use the core class, which has been in core since 5.8. * skinned the podcast player to fit design * add podcast player to the header of the single template * player on archive page too * Handle simple podcast player in filter * Categories archives: Hide the decorative archive title from screen readers (#233) * Categories archives: Hide the decorative archive title from screen readers Only the first letter is visible, and having this on the page for screen reader users causes a double heading. * Fix aria-hidden attribute * Pagination: Wrap long post titles onto a new line (#240) * Add editor styles in admin only The function `editor_styles` calls `fonts_url`, which in turn calls `WP_Theme_JSON_Resolver::get_merged_data`, which sets up some static variables. Running this on `after_setup_theme` sets up these static variables before all the blocks are registered, which breaks the stylesheet generation that happens later on to create `global-styles-inline-css`, causing everything in theme.json's styles.blocks property to be ignored. This avoids the issue by only calling `editor_styles` in the admin. * Blocks: Update styling for code block, add Code Syntax Block plugin * Switch to code-syntax-block plugin For this to take effect you'll need to run: `composer update && wp-env start --update` * Remove the border from code blocks * Update the code block styles in theme.json, remove workaround SCSS file Co-authored-by: Kelly Dwan <[email protected]> * Fix stroke and dot postioning on pagination (#239) * Ensuring the pager works with the blue background of the releases category. * Adjusting spacing and only showing a dot on the left if you're on a page other than the first. * Move the bullets to the previous/next buttons. * Fix lint issues Co-authored-by: Kelly Dwan <[email protected]> * skinned smaller player * fixed spacing and responsive * Offset vertical position of title mask by 1px (#249) * Layout: Stick content to top of page. (#247) * minimal player on mobile * fix broken block markup * fix share panel contrast * Adding focus styles for the player * fix focus on speed button * Add focus states for share buttons * fix focus states for player panels * add tablet styles * add an outline to focussed buttons * remove extra player * hide the share panels until they are opened * Readme: Add note that header/footer live in different repo. * Make the focus state of the small player more obvious * Don't show the word Archive on the podcast page * limit the height of the header on the category page * Add focus states for the pause button * Add a ligher player on the archive page * fix the pink blob positioning * linting changes * Modularize components/_local-header.scss (#250) * Modularize local-header CSS * Fix indentation * Simplify top level selectors * Add .local-header to start of breadcrumbs * Update source/wp-content/themes/wporg-news-2021/sass/components/local-header/_breadcrumbs.scss Co-authored-by: Ian Dunn <[email protected]> * Update source/wp-content/themes/wporg-news-2021/sass/components/local-header/_local-header.scss Co-authored-by: Kelly Dwan <[email protected]> * Linter changes Co-authored-by: Ian Dunn <[email protected]> Co-authored-by: Kelly Dwan <[email protected]> * Update hover states on the share and subscribe buttons * Make the category name static, since this is actually a custom post type not a category, and this tempalte is only used for that CPT * center the pink blob on mobile * add a spacer to the top of each post in the archive template * reduce spacer: * initial layout for podcast single post * remove unneeded rule * left column styles * positioning on mobile * fix rebase error * fixes for blob and overall padding * started header styles * template for archive page too * skinned the podcast player to fit design * add podcast player to the header of the single template * player on archive page too * Handle simple podcast player in filter * skinned smaller player * fixed spacing and responsive * minimal player on mobile * fix broken block markup * fix share panel contrast * Adding focus styles for the player * fix focus on speed button * Add focus states for share buttons * fix focus states for player panels * add tablet styles * add an outline to focussed buttons * remove extra player * hide the share panels until they are opened * Make the focus state of the small player more obvious * Don't show the word Archive on the podcast page * Add focus states for the pause button * Add a ligher player on the archive page * fix the pink blob positioning * linting changes * Update hover states on the share and subscribe buttons * Make the category name static, since this is actually a custom post type not a category, and this tempalte is only used for that CPT * center the pink blob on mobile * add a spacer to the top of each post in the archive template * reduce spacer: Co-authored-by: Sarah Norris <[email protected]> Co-authored-by: Kelly Dwan <[email protected]> Co-authored-by: tellyworth <[email protected]> Co-authored-by: Shaun Andrews <[email protected]> Co-authored-by: Ian Dunn <[email protected]> Co-authored-by: Ben Dwyer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
body.pageto the styling rule that sets the left and right padding tovar(--wp--custom--alignment--edge-spacing)for posts.Closes #226.