-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
404: Offset "oops" to match design #323
Conversation
The footer logo isn't just your env, it's an issue from the logo change yesterday. See WordPress/wporg-mu-plugins#162 |
I reduced the gap a bit in 74ca6fa (not deployed yet), but it's difficult to get it exact at every breakpoint, because of the dynamic font size. I don't think most of the extra gap is coming from that, though. When the viewport is bigger than the page content, the footer sticks to the bottom, so the extra gap is expected to some degree. |
a9fd18e fixes the search spacing. i'm going into a meeting, but will deploy it after that |
Looks like @ryelle synced and deployed it, thanks! @beafialho , you can see this on production now. LMK if you'd like any other changes. |
Thank you @iandunn, there's still too much space between the content and the footer, let's try to make the content sit in the middle of the page so that there's similar space above and below: |
Ah, ok, I didn't realize you wanted it vertically centered. I'll look into that. |
I got that mostly working in 388a4f0. It stops working once the viewport is |
Fixes #311
Follow up to #314.
margin-top
that wasn't affecting anythingThe black footer logo is just something off in my environment (also on
trunk
). I don't think it'll affect staging/prod.