404: Pass correct get_site_url param to avoid infinite loop
#98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first param to `get_site_url()` should be a site ID, or `null` for the current site. Passing a string can cause a `switch_to_blog( 0 )` in some circumstances. That breaks SQL queries because the table doesn't exist. The first broken query results in a `wp_die()`, but that leads to more queries which in turn call `wp_die()`. Passing `null` fixes the error while preserving the original intent from #54 (comment).
iandunn
added
[Type] Bug
renintw
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first param to
get_site_url()should be a site ID, ornullfor the current site. Passing a string can cause aswitch_to_blog( 0 )in some circumstances. That breaks SQL queries because the table doesn't exist. The first broken query results in awp_die(), but that leads to more queries which in turn callwp_die().Passing
nullfixes the error while preserving the original intent from #54 (comment).I ran into this while trying to activate the parent theme on
events.wordpress.orgfor WordPress/wordcamp.org#1007